Add `__attribute__((noreturn,cold))` for `_mi_assert_fail`

[picnixz]

Feature or enhancement

Note

I already have a PR ready in case this is accepted

Proposal:

Because _mi_assert_fail is not marked as a noreturn function, the assertion is not understood by CLion and I have some false positives telling me "this ptr is not NULL" while just above there is mi_assert(ptr != NULL);. To improve IDE's analysis, I suggest to mark _mi_assert_fail with __attribute__((noreturn)) and __THROW for GCC, the same attributes that are put on __assert_fail:

extern void __assert_fail (const char *__assertion, const char *__file,
			   unsigned int __line, const char *__function)
     __THROW __attribute__ ((__noreturn__));

cc @colesbury

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere.

Linked PRs

• gh-134586: mark _mi_assert_fail as noreturn, cold and throw #134624

[thesamesam]

You could mark it cold as well while at it. The equivalent in glibc has that with latest versions (f6f904745942540c7ea99c403b75b695ee560035, e3b0b3484cac61f9eae373751ac6eaf816a2c9c3).