gh-140272: Fix memory leak in _gdbm.gdbm.clear() (GH-140274)

ashm-dev · web-flow · commit f937468e7c88 · 2025-10-18T09:27:58.000Z
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-10-17-23-58-11.gh-issue-140272.lhY8uS.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-10-17-23-58-11.gh-issue-140272.lhY8uS.rst
@@ -0,0 +1 @@
+Fix memory leak in the :meth:`!clear` method of the :mod:`dbm.gnu` database.
diff --git a/Modules/_gdbmmodule.c b/Modules/_gdbmmodule.c
@@ -673,8 +673,10 @@ _gdbm_gdbm_clear_impl(gdbmobject *self, PyTypeObject *cls)
         }
         if (gdbm_delete(self->di_dbm, key) < 0) {
             PyErr_SetString(state->gdbm_error, "cannot delete item from database");
+            free(key.dptr);
             return NULL;
         }
+        free(key.dptr);
     }
     Py_RETURN_NONE;
 }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix memory leak in the :meth:`!clear` method of the :mod:`dbm.gnu` database.
Original file line number	Diff line number	Diff line change
`@@ -673,8 +673,10 @@ _gdbm_gdbm_clear_impl(gdbmobject self, PyTypeObject cls)`
`673`	`673`	`}`
`674`	`674`	`if (gdbm_delete(self->di_dbm, key) < 0) {`
`675`	`675`	`PyErr_SetString(state->gdbm_error, "cannot delete item from database");`
	`676`	`+ free(key.dptr);`
`676`	`677`	`return NULL;`
`677`	`678`	`}`
	`679`	`+ free(key.dptr);`
`678`	`680`	`}`
`679`	`681`	`Py_RETURN_NONE;`
`680`	`682`	`}`