Skip to content

Commit 8bf7be7

Browse files
committed
tests: polish
1 parent 4fb1392 commit 8bf7be7

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

Lib/test/test_concurrent_futures/executor.py

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,37 +75,35 @@ def test_map_with_buffersize(self):
7575
with self.assertRaisesRegex(ValueError, "buffersize must be None or >= 1."):
7676
self.executor.map(bool, [], buffersize=0)
7777

78-
it = range(4)
78+
iterable = range(4)
7979
self.assertEqual(
80-
list(self.executor.map(str, it, buffersize=1)),
81-
list(map(str, it)),
80+
list(self.executor.map(str, iterable, buffersize=1)),
81+
list(map(str, iterable)),
8282
)
8383

8484
def test_map_with_buffersize_and_timeout(self):
85-
it = self.executor.map(time.sleep, (0, 1), timeout=0.5)
86-
next(it)
85+
results = self.executor.map(time.sleep, (0, 1), timeout=0.5)
86+
next(results)
8787
with self.assertRaises(TimeoutError):
88-
next(it)
88+
next(results)
8989

9090
def test_map_with_buffersize_on_infinite_iterable(self):
9191
results = self.executor.map(str, itertools.count(1), buffersize=1)
9292
self.assertEqual(next(iter(results)), "1")
9393

9494
def test_map_with_buffersize_on_iterable_smaller_than_buffer(self):
95-
it = range(2)
96-
results = self.executor.map(str, it, buffersize=10)
97-
self.assertListEqual(list(results), list(map(str, it)))
95+
iterable = range(2)
96+
results = self.executor.map(str, iterable, buffersize=8)
97+
self.assertListEqual(list(results), list(map(str, iterable)))
9898

9999
def test_map_with_buffersize_on_empty_iterable(self):
100-
it = iter([])
101-
results = self.executor.map(str, it, buffersize=10)
100+
results = self.executor.map(str, [], buffersize=8)
102101
self.assertListEqual(list(results), [])
103102

104103
def test_map_with_buffersize_when_buffer_becomes_full(self):
105-
manager = multiprocessing.Manager()
106104
iterable = range(8)
107105
buffersize = 4
108-
buffered_results = manager.list()
106+
buffered_results = multiprocessing.Manager().list()
109107
self.executor.map(buffered_results.append, iterable, buffersize=buffersize)
110108
self.executor.shutdown(wait=True)
111109
self.assertSetEqual(

0 commit comments

Comments
 (0)