Commit 401fff7
authored
We need to return immediately if there's an error during dictionary
lookup.
Also avoid the conditional-if operator. MSVC versions through v19.27 miscompile
compound literals with side effects within a conditional operator. This caused
crashes in the Windows10 buildbot.
1 parent 9dacf43 commit 401fff7
1 file changed
+7
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1550 | 1550 | | |
1551 | 1551 | | |
1552 | 1552 | | |
1553 | | - | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
1554 | 1559 | | |
1555 | 1560 | | |
1556 | 1561 | | |
| |||
2483 | 2488 | | |
2484 | 2489 | | |
2485 | 2490 | | |
2486 | | - | |
| 2491 | + | |
2487 | 2492 | | |
2488 | 2493 | | |
2489 | 2494 | | |
| |||
0 commit comments