Skip to content

Commit 3600bb6

Browse files
committed
gh-141968: Use take_byes in encodings.punycode
Removes a copy going from bytearray to bytes.
1 parent 8c33c61 commit 3600bb6

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Lib/encodings/punycode.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def segregate(str):
1717
else:
1818
extended.add(c)
1919
extended = sorted(extended)
20-
return bytes(base), extended
20+
return base.take_bytes(), extended
2121

2222
def selective_len(str, max):
2323
"""Return the length of str, considering only characters below max."""
@@ -83,7 +83,7 @@ def generate_generalized_integer(N, bias):
8383
t = T(j, bias)
8484
if N < t:
8585
result.append(digits[N])
86-
return bytes(result)
86+
return result.take_bytes()
8787
result.append(digits[t + ((N - t) % (36 - t))])
8888
N = (N - t) // (36 - t)
8989
j += 1
@@ -112,7 +112,7 @@ def generate_integers(baselen, deltas):
112112
s = generate_generalized_integer(delta, bias)
113113
result.extend(s)
114114
bias = adapt(delta, points==0, baselen+points+1)
115-
return bytes(result)
115+
return result.take_bytes()
116116

117117
def punycode_encode(text):
118118
base, extended = segregate(text)
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Remove data copy from :mod:`codecs` ``punycode`` encoding by using
2+
:func:`bytearray.take_bytes`.

0 commit comments

Comments
 (0)