Move most of setuptools attributes to pyproject.toml #480
+64
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbean-bremen
commented
Dec 5, 2025
mrbean-bremen
commented
- ensures that the license metadata is correctly created
- see greenlet metadata should use License-Expression instead of License attribute #466
mrbean-bremen
commented
Dec 5, 2025
Comment on lines
234
to
235
| package_dir={'': 'src'}, | ||
| packages=find_packages('src'), |
Author
There was a problem hiding this comment.
These are strictly speaking not needed, but removing them broke the version test, as the output of setup.py --version contained a few lines related to auto-discovery of src-layout.
- ensures that the license metadata is correctly created
mrbean-bremen
force-pushed
the
pyproject.toml
branch
from
33b8fc4 to
ecbe979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.