Use importlib.import_module instead of __import__

As recommended by Python's documentation for `__import__`.

Author: bluetech

src/_pytest/config/__init__.py

@@ -18,6 +18,7 @@
 import enum
 from functools import lru_cache
 import glob
+import importlib
 import importlib.metadata
 import inspect
 import os
@@ -874,7 +875,13 @@ def import_plugin(self, modname: str, consider_entry_points: bool = False) -> No
                 return
 
         try:
-            __import__(importspec)
+            if sys.version_info >= (3, 11):
+                mod = importlib.import_module(importspec)
+            else:
+                # On Python 3.10, import_module breaks
+                # testing/test_config.py::test_disable_plugin_autoload.
+                __import__(importspec)
+                mod = sys.modules[importspec]
         except ImportError as e:
             raise ImportError(
                 f'Error importing plugin "{modname}": {e.args[0]}'
@@ -883,7 +890,6 @@ def import_plugin(self, modname: str, consider_entry_points: bool = False) -> No
         except Skipped as e:
             self.skipped_plugins.append((modname, e.msg or ""))
         else:
-            mod = sys.modules[importspec]
             self.register(mod, modname)
 
 
@@ -2122,7 +2128,7 @@ def _resolve_warning_category(category: str) -> type[Warning]:
         klass = category
     else:
         module, _, klass = category.rpartition(".")
-        m = __import__(module, None, None, [klass])
+        m = importlib.import_module(module)
     cat = getattr(m, klass)
     if not issubclass(cat, Warning):
         raise UsageError(f"{cat} is not a Warning subclass")

src/_pytest/debugging.py

@@ -8,6 +8,7 @@
 from collections.abc import Callable
 from collections.abc import Generator
 import functools
+import importlib
 import sys
 import types
 from typing import Any
@@ -122,8 +123,7 @@ def _import_pdb_cls(cls, capman: CaptureManager | None):
             modname, classname = usepdb_cls
 
             try:
-                __import__(modname)
-                mod = sys.modules[modname]
+                mod = importlib.import_module(modname)
 
                 # Handle --pdbcls=pdb:pdb.Pdb (useful e.g. with pdbpp).
                 parts = classname.split(".")

src/_pytest/monkeypatch.py

@@ -7,6 +7,7 @@
 from collections.abc import Mapping
 from collections.abc import MutableMapping
 from contextlib import contextmanager
+import importlib
 import os
 from pathlib import Path
 import re
@@ -66,7 +67,7 @@ def resolve(name: str) -> object:
     parts = name.split(".")
 
     used = parts.pop(0)
-    found: object = __import__(used)
+    found: object = importlib.import_module(used)
     for part in parts:
         used += "." + part
         try:
@@ -78,7 +79,7 @@ def resolve(name: str) -> object:
         # We use explicit un-nesting of the handling block in order
         # to avoid nested exceptions.
         try:
-            __import__(used)
+            importlib.import_module(used)
         except ImportError as ex:
             expected = str(ex).split()[-1]
             if expected == used:

src/_pytest/outcomes.py

@@ -3,6 +3,7 @@
 
 from __future__ import annotations
 
+import importlib
 import sys
 from typing import Any
 from typing import ClassVar
@@ -268,7 +269,7 @@ def importorskip(
         warnings.simplefilter("ignore")
 
         try:
-            __import__(modname)
+            importlib.import_module(modname)
         except exc_type as exc:
             # Do not raise or issue warnings inside the catch_warnings() block.
             if reason is None:

testing/acceptance_test.py

@@ -129,9 +129,9 @@ class DummyEntryPoint:
             group: str = "pytest11"
 
             def load(self):
-                __import__(self.module)
+                mod = importlib.import_module(self.module)
                 loaded.append(self.name)
-                return sys.modules[self.module]
+                return mod
 
         entry_points = [
             DummyEntryPoint("myplugin1", "mytestplugin1_module"),

testing/test_config.py

@@ -600,8 +600,7 @@ class DummyEntryPoint:
             group: str = "pytest11"
 
             def load(self):
-                __import__(self.module)
-                return sys.modules[self.module]
+                return importlib.import_module(self.module)
 
         entry_points = [
             DummyEntryPoint("myplugin1", "myplugin1_module"),

testing/test_pathlib.py

@@ -964,7 +964,7 @@ def test_demo():
         )
 
         # unit test
-        __import__(name)  # import standard library
+        importlib.import_module(name)  # import standard library
 
         import_path(  # import user files
             file_path,