Skip to content

Commit 3d95b52

Browse files
authored
Quote the arguments to pip (#209)
This fixes quoting in the pip arguments. Otherwise: ``` .venv-pyodide/bin/pip install 'pkg; sys_platform != "emscripten"' ``` will fail because the quotes are removed and it is interpretered as a request to install packages named pkg, sys_platform, !=, and emscripten. This fixes another regression introduced in #185.
1 parent 4ece0b3 commit 3d95b52

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## Unreleased
9+
10+
- Fixed a regression in quoting of pip arguments introduced in
11+
[#185](https://github.com/pyodide/pyodide-build/pull/185).
12+
[#209](https://github.com/pyodide/pyodide-build/pull/209)
13+
814
## [0.30.4] - 2025/05/20
915

1016
- Fixed compatibility with `virtualenv` 20.31 and later. The Pyodide virtual environment via `pyodide venv` no longer seeds

pyodide_build/out_of_tree/venv.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ def create_pip_script(venv_bin):
252252
dedent(
253253
f"""\
254254
#!/bin/sh
255-
exec env PYTHONHOME={pythonhome} {python_host_link} $@
255+
exec env PYTHONHOME={pythonhome} {python_host_link} "$@"
256256
"""
257257
)
258258
)

0 commit comments

Comments
 (0)