Mark old xType aliases as deprecated (#3288)

* Mark old xType aliases as deprecated

Doesn't touch JoystickType because the C code still works the old way I think, doesn't touch CameraType because CameraType is not in the stubs. In fact CameraType might be removable as an internal implementation detail.

* Mark old types deprecated: don't duplicate event

* Mark old types deprecated: clearer wording

Author: Starbuck5

buildconfig/stubs/pygame/event.pyi

@@ -1,9 +1,12 @@
 from typing import Any, Optional, Union, final
+from typing_extensions import deprecated  # added in 3.13
 
 from pygame.typing import SequenceLike
 
-@final
-class Event:
+class _GenericEvent:
+    # Just exists to avoid duplication of data for Event
+    # and (deprecated) EventType
+
     @property
     def type(self) -> int: ...
     __dict__: dict[str, Any]
@@ -21,6 +24,15 @@ class Event:
     @property
     def dict(self) -> dict[str, Any]: ...
 
+@final
+class Event(_GenericEvent):
+    pass
+
+@final
+@deprecated("Use `Event` instead (EventType is an old alias)")
+class EventType(_GenericEvent):
+    pass
+
 _EventTypes = Union[int, SequenceLike[int]]
 
 def pump() -> None: ...
@@ -41,5 +53,3 @@ def set_grab(grab: bool, /) -> None: ...
 def get_grab() -> bool: ...
 def post(event: Event, /) -> bool: ...
 def custom_type() -> int: ...
-
-EventType = Event

buildconfig/stubs/pygame/font.pyi

@@ -1,5 +1,6 @@
 from collections.abc import Callable, Hashable, Iterable
 from typing import Literal, Optional, Union
+from typing_extensions import deprecated  # added in 3.13
 
 from pygame.surface import Surface
 
@@ -87,4 +88,5 @@ class Font:
     def get_point_size(self) -> int: ...
     def set_point_size(self, val: int, /) -> None: ...
 
-FontType = Font
+@deprecated("Use `Font` instead (FontType is an old alias)")
+class FontType(Font): ...

buildconfig/stubs/pygame/mask.pyi

@@ -1,4 +1,5 @@
 from typing import Any, Optional, Union
+from typing_extensions import deprecated  # added in 3.13
 
 from pygame.rect import Rect
 from pygame.surface import Surface
@@ -54,4 +55,5 @@ class Mask:
         dest: Union[RectLike, Point] = (0, 0),
     ) -> Surface: ...
 
-MaskType = Mask
+@deprecated("Use `Mask` instead (MaskType is an old alias)")
+class MaskType(Mask): ...

buildconfig/stubs/pygame/mixer.pyi

@@ -1,4 +1,5 @@
 from typing import Any, Optional, Union, overload
+from typing_extensions import deprecated  # added in 3.13
 
 import numpy
 
@@ -100,5 +101,8 @@ class Channel:
     def set_endevent(self, type: Union[int, Event] = 0, /) -> None: ...
     def get_endevent(self) -> int: ...
 
-SoundType = Sound
-ChannelType = Channel
+@deprecated("Use `Sound` instead (SoundType is an old alias)")
+class SoundType(Sound): ...
+
+@deprecated("Use `Channel` instead (ChannelType is an old alias)")
+class ChannelType(Channel): ...

buildconfig/stubs/pygame/rect.pyi

@@ -8,6 +8,7 @@ from typing import (
     overload,
     Optional,
 )
+from typing_extensions import deprecated  # added in 3.13
 
 from pygame.typing import Point, RectLike, SequenceLike
 
@@ -285,5 +286,8 @@ class Rect(_GenericRect[int]):
 class FRect(_GenericRect[float]):
     ...
 
-RectType = Rect
-FRectType = FRect
+@deprecated("Use `Rect` instead (RectType is an old alias)")
+class RectType(Rect): ...
+
+@deprecated("Use `FRect` instead (FRectType is an old alias)")
+class FRectType(FRect): ...

buildconfig/stubs/pygame/surface.pyi

@@ -168,4 +168,5 @@ class Surface:
     def premul_alpha(self) -> Surface: ...
     def premul_alpha_ip(self) -> Surface: ...
 
-SurfaceType = Surface
+@deprecated("Use `Surface` instead (SurfaceType is an old alias)")
+class SurfaceType(Surface): ...