From c3ddc5a38746caad14eb8118c084eae50ca83c3d Mon Sep 17 00:00:00 2001 From: Gavin Didrichsen Date: Fri, 8 Aug 2025 11:21:09 +0100 Subject: [PATCH 1/5] fix: use github.run_number for BUILD_VERSION in nightly workflow Resolves npm version error in scheduled runs where github.event.number is undefined, causing invalid version string "0.99." Signed-off-by: Gavin Didrichsen --- .github/workflows/nightly.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 65346cd8..478184e7 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -62,7 +62,7 @@ jobs: - name: npm test env: - BUILD_VERSION: '0.99.${{ github.event.number }}' + BUILD_VERSION: 0.99.${{ github.run_number }} VSCODE_BUILD_VERBOSE: true DISPLAY: ':99.0' shell: pwsh @@ -72,7 +72,7 @@ jobs: - name: vsce package if: runner.os == 'Linux' env: - BUILD_VERSION: '0.99.${{ github.event.number }}' + BUILD_VERSION: 0.99.${{ github.run_number }} shell: pwsh run: | invoke-psake -properties @{ packageVersion = $env:BUILD_VERSION } -tasklist bump From 3a4fd10b842c8a899282ce056cf6e6dd550d9eaf Mon Sep 17 00:00:00 2001 From: Gavin Didrichsen Date: Mon, 11 Aug 2025 08:55:49 +0100 Subject: [PATCH 2/5] fix(ci): update Node.js version from 18 to 20 for vsce compatibility Resolves undici dependency compatibility issue where vsce packaging fails with "File is not defined" errors. The vsce tool's cheerio dependency pulls in undici v7.13.0+ which requires Node.js 20.18.1+ but workflow was using Node.js 18.20.8. Signed-off-by: Gavin Didrichsen --- .github/workflows/nightly.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 478184e7..dfe39782 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -10,7 +10,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [18] + node-version: [20] os: [ubuntu-latest, windows-latest, macos-latest] steps: From 7f67e5b40a1ca76ee957958950d0ca21ce27fcc3 Mon Sep 17 00:00:00 2001 From: Gavin Didrichsen Date: Mon, 11 Aug 2025 09:51:53 +0100 Subject: [PATCH 3/5] Update vscode-ci workflow to use Node.js 20 - Changes vscode-ci.yml matrix from node-version [18] to [20] - Resolves undici v7.13.0 compatibility issue in PR workflows - Aligns PR workflow with nightly workflow Node.js version - Fixes vsce packaging failure: 'File is not defined' error --- .github/workflows/vscode-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/vscode-ci.yml b/.github/workflows/vscode-ci.yml index 994b9a65..ca38cfcb 100644 --- a/.github/workflows/vscode-ci.yml +++ b/.github/workflows/vscode-ci.yml @@ -17,7 +17,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [18] + node-version: [20] os: [ubuntu-latest, windows-latest, macos-latest] steps: From 89a1cf6d7933f548d1a0bcf1c8bba094ba774483 Mon Sep 17 00:00:00 2001 From: Gavin Didrichsen Date: Mon, 11 Aug 2025 09:55:01 +0100 Subject: [PATCH 4/5] Update all workflows to use Node.js 20 for undici compatibility Signed-off-by: Gavin Didrichsen --- .github/workflows/mend.yml | 4 ++-- .github/workflows/release.yml | 2 +- .github/workflows/release_prep.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/mend.yml b/.github/workflows/mend.yml index 9c74c1e4..31170e32 100644 --- a/.github/workflows/mend.yml +++ b/.github/workflows/mend.yml @@ -14,10 +14,10 @@ jobs: steps: - uses: actions/checkout@v4 - - name: 'setup node: 18 platform: ${{ runner.os }}' + - name: 'setup node: 20 platform: ${{ runner.os }}' uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - name: npm install run: | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5baa1cf3..568f11f3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: env: - NODE_VERSION: '18.x' + NODE_VERSION: '20' jobs: release: diff --git a/.github/workflows/release_prep.yml b/.github/workflows/release_prep.yml index f68a896a..629f191d 100644 --- a/.github/workflows/release_prep.yml +++ b/.github/workflows/release_prep.yml @@ -16,7 +16,7 @@ jobs: name: "Release Prep" runs-on: "ubuntu-latest" env: - NODE_VERSION: "18" + NODE_VERSION: "20" steps: - name: "Checkout" From 5314644e96f3dafdec14cc40b038c8b074ef481a Mon Sep 17 00:00:00 2001 From: Gavin Didrichsen Date: Mon, 11 Aug 2025 10:50:38 +0100 Subject: [PATCH 5/5] Fix some syntax warnings. Signed-off-by: Gavin Didrichsen --- .github/workflows/vscode-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/vscode-ci.yml b/.github/workflows/vscode-ci.yml index ca38cfcb..e3481f76 100644 --- a/.github/workflows/vscode-ci.yml +++ b/.github/workflows/vscode-ci.yml @@ -9,7 +9,7 @@ on: - "main" workflow_dispatch: -env: +env: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} jobs: @@ -76,8 +76,8 @@ jobs: npm run test:coverage - name: Upload Coverage - if: | - runner.os == 'Linux' && + if: | + runner.os == 'Linux' && env.CODECOV_TOKEN != '' uses: codecov/codecov-action@v4 with: @@ -85,7 +85,7 @@ jobs: files: ./coverage.xml fail_ci_if_error: true verbose: true - + - name: vsce package if: runner.os == 'Linux' env: