feat: adding support for ssl on cdn endpoints #4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4154 +/- ##
=======================================
Coverage 58.08% 58.08%
=======================================
Files 84 84
Lines 13535 13535
=======================================
Hits 7862 7862
Misses 5081 5081
Partials 592 592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for enabling HTTPS on Azure CDN custom domains by introducing a new resource type, CustomDomainHttps, along with updates to SDKs for Python, Node.js, .NET, and an example demonstrating the usage.
- Adds CustomDomainHttps resource to enable/disable HTTPS and configure certificates.
- Updates code generation and token paths to include CustomDomainHttps.
- Provides an example (cdn-custom-domain-https) illustrating configuring HTTPS on a CDN custom domain.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/python/pulumi_azure_native/init.py | Adds CustomDomainHttps to the resource mapping. |
| sdk/nodejs/types/output.ts & input.ts | Introduces new interfaces for HTTPS configuration and certificate parameters. |
| sdk/nodejs/cdn/customDomainHttps.ts & index.ts | Implements the CustomDomainHttps resource and updates resource registration. |
| sdk/dotnet/Cdn/* | Adds generated .NET SDK files for CustomDomainHttps and associated configurations. |
| reports/tokenPaths.json | Updates token paths to include the new CustomDomainHttps endpoint. |
| provider/pkg/resources/customresources/customresources.go | Registers the new cdnCustomDomainHttps custom resource. |
| examples/cdn-custom-domain-https/* | Provides an example demonstrating HTTPS configuration for a CDN custom domain. |
| CLAUDE.md | Adds documentation and contributor guidance updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for enabling HTTPS on Azure CDN custom domains in the Pulumi Azure Native provider. It includes updates to the provider's codebase, new SDK resources, and an example demonstrating the feature.
New Feature: Support for HTTPS on CDN Custom Domains
CustomDomainHttps, to enable or disable HTTPS on Azure CDN custom domains. This includes support for configuring certificates (CDN-managed or Azure Key Vault) and TLS settings. (provider/pkg/resources/customresources/customresources.go[1]reports/tokenPaths.json[2]sdk/dotnet/Cdn/CustomDomainHttps.cs[3]Example Implementation
cdn-custom-domain-https, demonstrating how to enable HTTPS on a CDN custom domain using Pulumi. This includes:Pulumi.yamlconfiguration file. (examples/cdn-custom-domain-https/Pulumi.yamlexamples/cdn-custom-domain-https/Pulumi.yamlR1-R3)index.ts. (examples/cdn-custom-domain-https/index.tsexamples/cdn-custom-domain-https/index.tsR1-R52)package.jsonandtsconfig.json. (examples/cdn-custom-domain-https/package.json[1]examples/cdn-custom-domain-https/tsconfig.json[2]SDK Updates
CustomDomainHttpsresource and its associated configurations:CustomDomainHttpsresource definition. (sdk/dotnet/Cdn/CustomDomainHttps.cssdk/dotnet/Cdn/CustomDomainHttps.csR1-R104)sdk/dotnet/Cdn/Inputs/HttpsConfigurationArgs.cs[1]sdk/dotnet/Cdn/Inputs/CdnCertificateSourceParametersArgs.cs[2]sdk/dotnet/Cdn/Inputs/KeyVaultCertificateSourceParametersArgs.cs[3]sdk/dotnet/Cdn/Outputs/HttpsConfiguration.cs[4]sdk/dotnet/Cdn/Outputs/CdnCertificateSourceParameters.cs[5]Documentation
CLAUDE.mdfile providing comprehensive guidance for contributors and users of the repository, including build commands, architecture overview, and development workflows. (CLAUDE.mdCLAUDE.mdR1-R160)