Nightly upgrade failed #2694
Description
https://github.com/pulumi/pulumi-azure-native/actions/runs/6020761074/job/16332772320?pr=2690
Dotnet build failing with:
Error: /home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/KeyVault/Enums.cs(284,51): error CS0102: The type 'KeyRotationPolicyActionType' already contains a definition for 'Rotate' [/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/Pulumi.AzureNative.csproj]
Error: /home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/KeyVault/V20230201/Enums.cs(284,51): error CS0102: The type 'KeyRotationPolicyActionType' already contains a definition for 'Rotate' [/home/runner/work/pulumi-azure-native/pulumi-azure-native/sdk/dotnet/Pulumi.AzureNative.csproj]
SDK Change
+ /// <summary>
+ /// Rotate the key based on the key policy. Key Vault only. Managed HSM uses camelCase 'rotate' instead.
+ /// </summary>
+ public static KeyRotationPolicyActionType Rotate { get; } = new KeyRotationPolicyActionType("Rotate");
+ /// <summary>
+ /// Rotate the key based on the key policy. Managed HSM only. Key Vault uses PascalCase 'Rotate' instead.
+ /// </summary>
public static KeyRotationPolicyActionType Rotate { get; } = new KeyRotationPolicyActionType("rotate");It's adding a second property called Rotate except that the property value has Title casing.
Upstream Change
"enum": [
+ "Rotate",
"rotate",
- "notify"
+ "Notify"
],Looks like the case was changed to be title case but the lowercase rotate was left in.
Actions
- Confirm codegen expects values to not vary by only case.
- Open issue to codify this with a schema validation check to fail fast with a helpful message.
- This looks like a mistake on the part of Microsoft, so we should report this upstream.
- Commented back on the PR where there's also discussion from Hashicorp who have been broken by this change.
- Fix by ignoring subsequent enum values which already exist when ignoring case