Remove dollar prefixing when ignoreDollarVariable is set to true

Author: kylekatarnls

src/JsPhpize/Compiler/Compiler.php

@@ -335,8 +335,11 @@ protected function visitVariable(Variable $variable, $indent)
         if ($variable->scope) {
             $name = '__let_' . spl_object_hash($variable->scope) . $name;
         }
+        if (!$this->engine->getOption('ignoreDollarVariable') || mb_substr($name, 0, 1) !== '$') {
+            $name = '$' . $name;
+        }
 
-        return $this->handleVariableChildren($variable, $indent, '$' . $name);
+        return $this->handleVariableChildren($variable, $indent, $name);
     }
 
     public function compile(Block $block, $indent = '')

tests/render.php

@@ -122,4 +122,16 @@ public function __get($name)
         $result = $jsPhpize->renderCode('return obj.arrayData.foo', $data);
         $this->assertSame('a-bar', (string) $result);
     }
+
+    public function testDollarVariablePrefix()
+    {
+        $jsPhpize = new JsPhpize([
+            'ignoreDollarVariable' => true,
+        ]);
+        $code = 'return isset($variable) && $variable !== false';
+
+        $this->assertFalse($jsPhpize->renderCode($code));
+        $this->assertTrue($jsPhpize->renderCode($code, ['variable' => 1]));
+        $this->assertFalse($jsPhpize->renderCode($code, ['variable' => false]));
+    }
 }