Skip to content

Commit a802809

Browse files
authored
Merge pull request #409 from gianlucam76/release-1.1
(bug) fix classifier RBACs
2 parents 7f2e80e + e19365a commit a802809

File tree

3 files changed

+20
-0
lines changed

3 files changed

+20
-0
lines changed

config/rbac/role.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,14 @@ rules:
2121
- get
2222
- list
2323
- watch
24+
- apiGroups:
25+
- apps
26+
resources:
27+
- deployments
28+
verbs:
29+
- get
30+
- list
31+
- watch
2432
- apiGroups:
2533
- authentication.k8s.io
2634
resources:

controllers/classifier_controller.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ type ClassifierReconciler struct {
130130
//+kubebuilder:rbac:groups=cluster.x-k8s.io,resources=machines/status,verbs=get;watch;list
131131
//+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch
132132
//+kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch
133+
//+kubebuilder:rbac:groups="apps",resources=deployments,verbs=get;list;watch
133134

134135
func (r *ClassifierReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Result, reterr error) {
135136
if r.ShardKey != "" {
@@ -557,6 +558,9 @@ func (r *ClassifierReconciler) updateLabelsOnMatchingClusters(ctx context.Contex
557558
ref := &classifierScope.Classifier.Status.MachingClusterStatuses[i].ClusterRef
558559
cluster, err := clusterproxy.GetCluster(ctx, r.Client, ref.Namespace, ref.Name, clusterproxy.GetClusterType(ref))
559560
if err != nil {
561+
if apierrors.IsNotFound(err) {
562+
continue
563+
}
560564
logger.V(logs.LogInfo).Error(err, fmt.Sprintf("failed to get cluster %s/%s", ref.Namespace, ref.Name))
561565
return err
562566
}

manifest/manifest.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,14 @@ rules:
3131
- get
3232
- list
3333
- watch
34+
- apiGroups:
35+
- apps
36+
resources:
37+
- deployments
38+
verbs:
39+
- get
40+
- list
41+
- watch
3442
- apiGroups:
3543
- authentication.k8s.io
3644
resources:

0 commit comments

Comments
 (0)