Mark it as Evil and make overload

PatrickRUG · PatrickRUG · commit 527ca37cfd1e · 2025-11-13T13:32:14.000+01:00
diff --git a/src/ProgressOnderwijsUtils/SingleSignOn/SsoProcessor.cs b/src/ProgressOnderwijsUtils/SingleSignOn/SsoProcessor.cs
@@ -44,7 +44,10 @@ static string EncodeQueryParameter(string key, string value)
         return null;
     }
 
-    public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate, bool ignoreSignatureCheck = false)
+    public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate)
+        => GetAttributes(rawSamlResponse, certificate, false);
+
+    public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate, bool evilIgnoreSignatureCheck)
     {
         byte[] bytes;
         try {
@@ -85,7 +88,7 @@ public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse,
             return Maybe.Error("Public key missing");
         }
 
-        if (!dsig.CheckSignature(key) && !ignoreSignatureCheck) {
+        if (!dsig.CheckSignature(key) && !evilIgnoreSignatureCheck) {
             return Maybe.Error("Signature invalid");
         }
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,10 @@ static string EncodeQueryParameter(string key, string value)`
`44`	`44`	`return null;`
`45`	`45`	`}`
`46`	`46`
`47`		`- public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate, bool ignoreSignatureCheck = false)`
	`47`	`+ public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate)`
	`48`	`+ => GetAttributes(rawSamlResponse, certificate, false);`
	`49`	`+`
	`50`	`+ public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate, bool evilIgnoreSignatureCheck)`
`48`	`51`	`{`
`49`	`52`	`byte[] bytes;`
`50`	`53`	`try {`
`@@ -85,7 +88,7 @@ public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse,`
`85`	`88`	`return Maybe.Error("Public key missing");`
`86`	`89`	`}`
`87`	`90`
`88`		`- if (!dsig.CheckSignature(key) && !ignoreSignatureCheck) {`
	`91`	`+ if (!dsig.CheckSignature(key) && !evilIgnoreSignatureCheck) {`
`89`	`92`	`return Maybe.Error("Signature invalid");`
`90`	`93`	`}`
`91`	`94`