Merge pull request #1210 from progressonderwijs/revert-1208-patrick/optionally_check_signature

Revert "Add an option to ignore signature validation"

Author: tjibbechris

src/ProgressOnderwijsUtils/SingleSignOn/SsoProcessor.cs

@@ -45,13 +45,6 @@ static string EncodeQueryParameter(string key, string value)
     }
 
     public static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate)
-        => GetAttributes(rawSamlResponse, certificate, false);
-
-    [Obsolete("This method ignores signature validation and should not be used in production code")]
-    public static Maybe<SsoAttributes, string> GetAttributesWithEvilIgnoreSignatureCheck(string rawSamlResponse, X509Certificate2 certificate)
-        => GetAttributes(rawSamlResponse, certificate, true);
-
-    static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Certificate2 certificate, bool evilIgnoreSignatureCheck)
     {
         byte[] bytes;
         try {
@@ -92,7 +85,7 @@ static Maybe<SsoAttributes, string> GetAttributes(string rawSamlResponse, X509Ce
             return Maybe.Error("Public key missing");
         }
 
-        if (!dsig.CheckSignature(key) && !evilIgnoreSignatureCheck) {
+        if (!dsig.CheckSignature(key)) {
             return Maybe.Error("Signature invalid");
         }