fix: LLM validation hangs on welcome state (#176)

Author: magesh-presidio

.changeset/three-numbers-cough.md

@@ -0,0 +1,5 @@
+---
+"hai-build-code-generator": patch
+---
+
+Resolved an issue where LLM validation could become stuck in the welcome state, preventing further progress.

.github/workflows/release.yml

@@ -3,7 +3,7 @@ name: "Release"
 on:
     push:
         branches:
-            - release
+            - main
     workflow_dispatch:
 
 permissions:

src/core/controller/index.ts

@@ -158,12 +158,29 @@ export class Controller {
 	// TAG:HAI
 	private async getExpertManager(): Promise<ExpertManager> {
 		if (!this.expertManager) {
-			const { embeddingConfiguration } = await getAllExtensionState(this.context, this.workspaceId)
-			this.expertManager = new ExpertManager(this.context, this.workspaceId, embeddingConfiguration)
+			this.expertManager = new ExpertManager(this.context, this.workspaceId)
 		}
 		return this.expertManager
 	}
 
+	/**
+	 * Initialize embeddings in ExpertManager
+	 */
+	public async initializeExpertManagerEmbeddings(): Promise<void> {
+		if (!this.expertManager) {
+			this.expertManager = new ExpertManager(this.context, this.workspaceId)
+		}
+		const { embeddingConfiguration } = await getAllExtensionState(this.context, this.workspaceId)
+		const embeddingHandler = buildEmbeddingHandler({
+			...embeddingConfiguration,
+			maxRetries: 0,
+		})
+		const isEmbeddingValid = await embeddingHandler.validateAPIKey()
+		if (isEmbeddingValid) {
+			this.expertManager.initializeEmbeddings(embeddingConfiguration)
+		}
+	}
+
 	/*
 	VSCode extensions use the disposable pattern to clean up resources when the sidebar/editor tab is closed by the user or system. This applies to event listening, commands, interacting with the UI, etc.
 	- https://vscode-docs.readthedocs.io/en/stable/extensions/patterns-and-principles/

src/core/experts/ExpertManager.ts

@@ -21,23 +21,29 @@ export class ExpertManager {
 	private workspaceId: string
 	private fileManager: ExpertFileManager
 	private documentProcessor: DocumentProcessor
-	private vectorStoreManager: VectorStoreManager
+	private vectorStoreManager?: VectorStoreManager
 
 	/**
 	 * Create a new ExpertManager
 	 */
-	constructor(extensionContext: vscode.ExtensionContext, workspaceId: string, embeddingConfig: EmbeddingConfiguration) {
+	constructor(extensionContext: vscode.ExtensionContext, workspaceId: string) {
 		this.extensionContext = extensionContext
 		this.workspaceId = workspaceId
 		this.fileManager = new ExpertFileManager()
 		this.documentProcessor = new DocumentProcessor(extensionContext, workspaceId)
 
-		// Initialize embedding client and vector store manager
+		// No embedding initialization here
+	}
+
+	/**
+	 * Initialize embedding client and vector store manager
+	 */
+	public initializeEmbeddings(embeddingConfig: EmbeddingConfiguration): void {
 		const embeddings = VectorStoreManager.initializeEmbeddings(embeddingConfig)
 		this.vectorStoreManager = new VectorStoreManager({
 			embeddings,
 			embeddingConfig,
-			workspaceId,
+			workspaceId: this.workspaceId,
 		})
 
 		this.connectProcessorToVectorStore()
@@ -134,6 +140,9 @@ export class ExpertManager {
 			suburl: string,
 			title?: string,
 		): Promise<void> => {
+			if (!this.vectorStoreManager) {
+				throw new Error("Vector store manager not initialized. Please initialize embeddings first.")
+			}
 			await this.vectorStoreManager.chunkAndStore({
 				markdown,
 				expertName,
@@ -165,6 +174,9 @@ export class ExpertManager {
 
 		if (isDeepCrawl) {
 			// For deepcrawl experts, delete chunks and re-crawl
+			if (!this.vectorStoreManager) {
+				throw new Error("Vector store manager not initialized. Please initialize embeddings first.")
+			}
 			await this.vectorStoreManager.deleteChunk(linkUrl, expertName, workspacePath)
 			await this.documentProcessor.crawlAndConvertToMarkdown(
 				linkUrl,
@@ -321,7 +333,9 @@ export class ExpertManager {
 		const isDeepCrawl = metadata.deepCrawl || false
 
 		// Delete from vector DB regardless (since the URL might have been crawled before)
-		await this.vectorStoreManager.deleteChunk(linkUrl, expertName, workspacePath)
+		if (this.vectorStoreManager) {
+			await this.vectorStoreManager.deleteChunk(linkUrl, expertName, workspacePath)
+		}
 
 		// Update regular status.json if it exists
 		if (await this.fileManager.readStatusFile(statusFilePath)) {
@@ -783,6 +797,9 @@ export class ExpertManager {
 	 * Search for a query in the expert's vector store
 	 */
 	async search(query: string, expertName: string, workspacePath: string, k?: number): Promise<string> {
+		if (!this.vectorStoreManager) {
+			throw new Error("Vector store manager not initialized. Please initialize embeddings first.")
+		}
 		return this.vectorStoreManager.search(query, expertName, workspacePath, k)
 	}
 }

src/core/task/index.ts

@@ -4646,7 +4646,8 @@ export class Task {
 						this.consecutiveMistakeCount = 0
 
 						// Create ExpertManager instance and search for the query
-						const expertManager = new ExpertManager(this.context, this.taskId, this.embeddingConfiguration)
+						const expertManager = new ExpertManager(this.context, this.taskId)
+						expertManager.initializeEmbeddings(this.embeddingConfiguration)
 						const searchResults = await expertManager.search(query, expertName, cwd)
 
 						// Format the complete message with search results

src/extension.ts

@@ -217,6 +217,7 @@ export async function activate(context: vscode.ExtensionContext) {
 			WebviewProvider.getAllInstances().forEach((instance) => {
 				const openExperts = async (instance?: WebviewProvider) => {
 					await instance?.controller.postStateToWebview()
+					instance?.controller.initializeExpertManagerEmbeddings()
 					instance?.controller.postMessageToWebview({
 						type: "action",
 						action: "expertsButtonClicked",

webview-ui/src/components/experts/ExpertsView.tsx

@@ -735,6 +735,37 @@ const ExpertsView: React.FC<ExpertsViewProps> = ({ onDone }) => {
 										/>
 										<p className="description-text">Sets the crawl timeout for each page.</p>
 									</FormGroup>
+									{deepCrawl && (
+										<div
+											className="info-message"
+											style={{
+												display: "flex",
+												alignItems: "flex-start",
+												gap: "8px",
+												color: "var(--vscode-foreground)",
+												fontSize: "12px",
+												padding: "8px",
+												backgroundColor: "var(--vscode-editorWidget-background)",
+												border: "1px solid var(--vscode-widget-border)",
+												borderRadius: "4px",
+												marginBottom: "16px",
+											}}>
+											<i
+												className="codicon codicon-info"
+												style={{
+													fontSize: "14px",
+													marginTop: "2px",
+													color: "var(--vscode-textLink-foreground)",
+												}}
+											/>
+											<span>
+												Important: If you change the embedding configuration, any experts with DeepCrawl
+												enabled must be deleted and recreated using the updated settings. Experts rely on
+												a consistent embedding setup — using different configurations can prevent them
+												from functioning properly.
+											</span>
+										</div>
+									)}
 								</>
 							)}
 							{!isEmbeddingValid && (