Upgrade lints

Author: simolus3

sqlite3/lib/common.dart

@@ -1,6 +1,6 @@
 /// Exports common interfaces that are implemented by both the `dart:ffi` and
 /// the `dart:js` WASM version of this library.
-library sqlite3.common;
+library;
 
 export 'src/constants.dart';
 export 'src/database.dart';

sqlite3/lib/open.dart

@@ -1,6 +1,6 @@
 /// Utils to open a [DynamicLibrary] on platforms that aren't supported by
 /// default.
-library open;
+library;
 
 import 'dart:ffi';
 

sqlite3/lib/sqlite3.dart

@@ -1,5 +1,5 @@
 /// Dart bindings to `sqlite3`.
-library sqlite3;
+library;
 
 // Hide common base classes that have more specific ffi-APIs.
 export 'common.dart' hide CommonPreparedStatement, CommonDatabase;

sqlite3/lib/src/ffi/bindings.dart

@@ -299,13 +299,10 @@ final class FfiDatabase extends RawSqliteDatabase {
 
   static Pointer<NativeFunction<Void Function(Pointer<Void>)>> _xDestroy(
       List<NativeCallable> callables) {
-    int destroy(Pointer<Void> _) {
+    void destroy(Pointer<Void> _) {
       for (final callable in callables) {
         callable.close();
       }
-
-      // TODO: Remove and change to void after Dart 3.5 or https://github.com/dart-lang/sdk/issues/56064
-      return 0;
     }
 
     final callable =
@@ -715,8 +712,6 @@ extension on RawXFunc {
     return NativeCallable.isolateLocal((Pointer<sqlite3_context> ctx, int nArgs,
         Pointer<Pointer<sqlite3_value>> args) {
       this(FfiContext(bindings, ctx), _ValueList(nArgs, args, bindings));
-      // TODO: Remove and change to void after Dart 3.5 or https://github.com/dart-lang/sdk/issues/56064
-      return 0;
     })
       ..keepIsolateAlive = false;
   }
@@ -728,8 +723,6 @@ extension on RawXFinal {
       final context = FfiContext(bindings, ctx);
       this(context);
       if (clean) context.freeContext();
-      // TODO: Remove and change to void after Dart 3.5 or https://github.com/dart-lang/sdk/issues/56064
-      return 0;
     })
       ..keepIsolateAlive = false;
   }
@@ -762,9 +755,6 @@ extension on RawUpdateHook {
           Pointer<sqlite3_char> table, int rowid) {
         final tableName = table.readString();
         this(kind, tableName, rowid);
-
-        // TODO: Remove and change to void after Dart 3.5 or https://github.com/dart-lang/sdk/issues/56064
-        return 0;
       },
     )..keepIsolateAlive = false;
   }

sqlite3/lib/src/implementation/bindings.dart

@@ -1,5 +1,5 @@
 @internal
-library sqlite3.implementation.bindings;
+library;
 
 import 'dart:typed_data';
 

sqlite3/lib/src/wasm/vfs/indexed_db.dart

@@ -189,7 +189,8 @@ class AsynchronousIndexedDbFileSystem {
     while (await iterator.moveNext()) {
       final row = iterator.current;
 
-      final rowOffset = (row.key! as List)[1] as int;
+      final key = (row.key as JSArray).toDart;
+      final rowOffset = (key[1] as JSNumber).toDartInt;
       final blob = row.value as web.Blob;
       final dataLength = min(blob.size, file.length - rowOffset);
 

sqlite3/lib/wasm.dart

@@ -12,7 +12,7 @@
 /// As long as this library is marked as experimental, it is not subject to
 /// semantic versioning.
 @experimental
-library sqlite3.wasm;
+library;
 
 import 'package:meta/meta.dart';
 

sqlite3/pubspec.yaml

@@ -5,7 +5,7 @@ homepage: https://github.com/simolus3/sqlite3.dart/tree/main/sqlite3
 issue_tracker: https://github.com/simolus3/sqlite3.dart/issues
 
 environment:
-  sdk: '>=3.4.0 <4.0.0'
+  sdk: '>=3.5.0 <4.0.0'
 
 # This package supports all platforms listed below.
 platforms:
@@ -36,7 +36,7 @@ dev_dependencies:
   build_web_compilers: ^4.0.3
   ffigen: ^13.0.0
   http: ^1.2.1
-  lints: ^4.0.0
+  lints: ^5.0.0
   shelf: ^1.4.0
   shelf_proxy: ^1.0.2
   shelf_static: ^1.1.0

sqlite3_web/lib/src/client.dart

@@ -98,7 +98,7 @@ final class RemoteDatabase implements Database {
   @override
   Future<int> get lastInsertRowId async {
     final result = await select('select last_insert_rowid();');
-    return result.single[0] as int;
+    return result.single.columnAt(0) as int;
   }
 
   @override
@@ -129,7 +129,7 @@ final class RemoteDatabase implements Database {
   @override
   Future<int> get userVersion async {
     final result = await select('pragma user_version;');
-    return result.single[0] as int;
+    return result.single.columnAt(0) as int;
   }
 
   @override

sqlite3_web/pubspec.yaml

@@ -13,7 +13,7 @@ dependencies:
   web: ^1.0.0
 
 dev_dependencies:
-  lints: ^2.1.0
+  lints: ^5.0.0
   test: ^1.25.5
   build_web_compilers: ^4.0.9
   build_runner: ^2.4.8