Merge pull request #637 from hackle/patch-1

posabsolute · posabsolute · commit 8c067443f348 · 2013-06-11T08:31:30.000-07:00
equals should be validated even empty
diff --git a/js/jquery.validationEngine.js b/js/jquery.validationEngine.js
@@ -704,7 +704,10 @@
 				}	
 			}
 			// If the rules required is not added, an empty field is not validated
-			if(!required && !(field.val()) && field.val().length < 1) options.isError = false;
+			//the 3rd condition is added so that even empty password fields should be equal
+			//otherwise if one is filled and another left empty, the "equal" condition would fail
+			//which does not make any sense
+			if(!required && !(field.val()) && field.val().length < 1 && rules.indexOf("equals") < 0) options.isError = false;
 
 			// Hack for radio/checkbox group button, the validation go into the
 			// first radio/checkbox of the group

Original file line number	Diff line number	Diff line change
`@@ -704,7 +704,10 @@`
`704`	`704`	`}`
`705`	`705`	`}`
`706`	`706`	`// If the rules required is not added, an empty field is not validated`
`707`		`- if(!required && !(field.val()) && field.val().length < 1) options.isError = false;`
	`707`	`+ //the 3rd condition is added so that even empty password fields should be equal`
	`708`	`+ //otherwise if one is filled and another left empty, the "equal" condition would fail`
	`709`	`+ //which does not make any sense`
	`710`	`+ if(!required && !(field.val()) && field.val().length < 1 && rules.indexOf("equals") < 0) options.isError = false;`
`708`	`711`
`709`	`712`	`// Hack for radio/checkbox group button, the validation go into the`
`710`	`713`	`// first radio/checkbox of the group`