fix

posabsolute · posabsolute · commit 3f841f4eacc6 · 2012-10-23T07:59:22.000-04:00
diff --git a/js/jquery.validationEngine.js b/js/jquery.validationEngine.js
@@ -679,7 +679,7 @@
 				}	
 			}
 			// If the rules required is not added, an empty field is not validated
-			if(!required && field.val().length < 1) options.isError = false;
+			if(!required && field.val() && field.val().length < 1) options.isError = false;
 
 			// Hack for radio/checkbox group button, the validation go into the
 			// first radio/checkbox of the group
diff --git a/tests/issue493 b/tests/issue493
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <title>Issue #451</title>
+    <meta charset="UTF-8" />
+    <link rel="stylesheet" type="text/css" href="../css/validationEngine.jquery.css" />
+    <script type="text/javascript" src="../js/jquery-1.7.2.min.js"></script>
+    <script type="text/javascript" src="../js/languages/jquery.validationEngine-en.js"></script>
+    <script type="text/javascript" src="../js/jquery.validationEngine.js"></script>
+    <script type="text/javascript">
+      $(document).ready(function() {
+
+        $('#id1').validationEngine('validate');
+      });
+    </script>
+  </head>
+  <body>
+   
+    <p>
+      See <a href="https://github.com/posabsolute/jQuery-Validation-Engine/issues/493">https://github.com/posabsolute/jQuery-Validation-Engine/issues/493</a>
+      for information.
+    </p>
+<form id="form">
+    <label for="id1">
+        ID1
+    </label>        
+    <input id="id1" name="id1" class="validate[required]" type="text"/>
+</form>
+  </body>
+</html>
diff --git a/tests/issue507.html b/tests/issue507.html
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <title>Issue #430: Do not validate empty fields that is not required.</title>
+    <meta charset="UTF-8" />
+    <link rel="stylesheet" type="text/css" href="../css/validationEngine.jquery.css" />
+    <script type="text/javascript" src="../js/jquery-1.7.2.min.js"></script>
+    <script type="text/javascript" src="../js/languages/jquery.validationEngine-en.js"></script>
+    <script type="text/javascript" src="../js/jquery.validationEngine.js"></script>
+    <script type="text/javascript">
+      $(document).ready(function () {
+
+      $("#f").submit(function (event) {
+        event.preventDefault();
+        return false;
+      });
+
+      $("#f").validationEngine({
+
+            customFunctions : {
+                v : function(field, rules, i, options) {
+                    if ($("#f").length === 0) {
+                        return options.allrules.required.alertText;
+                    }
+                }
+            }
+
+      });
+
+
+      });
+    </script>
+  </head>
+  <body>
+    <form id="f" style="margin:100px;">
+      <!-- Note that the select has no 'options', and we want a custom function to validate it -->
+      <select id="s" class="validate[funcCall[v]]"></select>
+      <input id="i" type="submit"></input>
+    </form>
+</html>

Original file line number	Diff line number	Diff line change
`@@ -679,7 +679,7 @@`
`679`	`679`	`}`
`680`	`680`	`}`
`681`	`681`	`// If the rules required is not added, an empty field is not validated`
`682`		`- if(!required && field.val().length < 1) options.isError = false;`
	`682`	`+ if(!required && field.val() && field.val().length < 1) options.isError = false;`
`683`	`683`
`684`	`684`	`// Hack for radio/checkbox group button, the validation go into the`
`685`	`685`	`// first radio/checkbox of the group`