Test that readShort() behaves properly with too much and too little data

this is a half-assed test, but readShort() is fairly representative of most of the code, so it should be good enough for now.

Author: dktapps

tests/phpunit/BinaryTest.php

@@ -36,4 +36,19 @@ public function testReadSignedByteWithEmptyString() : void{
 		$this->expectException(BinaryDataException::class);
 		Binary::readSignedByte("");
 	}
+
+	/**
+	 * Passing too much data is OK; we just take the first N bytes as needed.
+	 */
+	public function testReadShortTooMuchData() : void{
+		$expected = 19132;
+		$data = Binary::writeShort($expected) . "\x00\x00";
+		$number = Binary::readShort($data);
+		self::assertSame($expected, $number);
+	}
+
+	public function testReadShortNotEnoughData() : void{
+		$this->expectException(BinaryDataException::class);
+		Binary::readShort("\x01");
+	}
 }