Create Variant Ids loop cleanup and test.

Author: Richard deMeester

product_configurator/models/product.py

@@ -472,10 +472,10 @@ def name_search(self, name='', args=None, operator='ilike', limit=100):
     def create_variant_ids(self):
         """ Prevent configurable products from creating variants as these serve
             only as a template for the product configurator"""
-        for product in self:
-            if self.config_ok:
-                return None
-            return super(ProductTemplate, self).create_variant_ids()
+        templates = self.filtered(lambda t: not t.config_ok)
+        if not templates:
+            return None
+        return super(ProductTemplate, templates).create_variant_ids()
 
     @api.multi
     def unlink(self):

product_configurator/tests/__init__.py

@@ -1,3 +1,3 @@
 # -*- coding: utf-8 -*-
 
-from . import test_configuration_rules
+from . import test_configuration_rules, test_create

product_configurator/tests/test_create.py

@@ -0,0 +1,42 @@
+# -*- coding: utf-8 -*-
+
+from odoo.tests.common import TransactionCase
+
+
+class ConfigurationCreate(TransactionCase):
+
+    def test_create(self):
+        """Test configuration item does not make variations"""
+
+        attr_test = self.env['product.attribute'].create(
+            {'name': 'Test',
+             'value_ids': [
+                 (0, 0, {'name': '1'}),
+                 (0, 0, {'name': '2'}),
+                 ],
+             }
+        )
+        test_template = self.env['product.template'].create(
+            {'name': 'Test Configuration',
+             'config_ok': True,
+             'type': 'product',
+             'categ_id': self.env['ir.model.data'].xmlid_to_res_id(
+                 'product.product_category_5'
+             ),
+             'attribute_line_ids': [
+                 (0, 0, {'attribute_id': attr_test.id,
+                         'value_ids': [
+                             (6, 0, attr_test.value_ids.ids),
+                             ],
+                         'required': True,
+                         }),
+                 ]
+             }
+        )
+
+        self.assertEqual(
+            test_template.product_variant_count,
+            0,
+            "Create should not have any variants"
+            )
+