refactoring the validate delete method returning string :d

Author: piotr-mamenas

Core/Domain/Partners/Partner.cs

@@ -39,23 +39,22 @@ protected Partner()
             Accounts = null;
         }
 
-        /// <summary>
-        /// 
-        /// </summary>
-        /// <returns></returns>
-        public string ValidateDelete ()
+        public bool CanDelete (out string errorMessage)
         {
+            errorMessage = string.Empty;
             if (Contacts.Any())
             {
-                return "Partner has existing Contacts";
+                errorMessage = "Partner has existing Contacts";
+                return false;
             }
 
             if (Accounts.Any())
             {
-                return "Partner has existing Accounts";
+                errorMessage = "Partner has existing Accounts";
+                return false;
             }
-
-            return null;
+            
+            return true;
         }
     }
 }

Service/Controllers/PartnerApiController.cs

@@ -111,10 +111,8 @@ public async Task<IHttpActionResult> DeleteAsync(int id)
             {
                 return NotFound();
             }
-
-            var deletionError = partner.ValidateDelete();
-
-            if (deletionError != null)
+;
+            if (partner.CanDelete(out string deletionError))
             {
                 var httpError = new HttpError(deletionError);