Skip to content

Commit ed2d492

Browse files
committed
ci: check missing runners only when needed
1 parent af302c0 commit ed2d492

File tree

3 files changed

+3
-25
lines changed

3 files changed

+3
-25
lines changed

.gitlab/ci/build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ generate_build_child_pipeline:
264264
dependencies: # set dependencies to null to avoid missing artifacts issue
265265
needs:
266266
- pipeline_variables
267-
- check_test_cases_env_markers_and_required_runners
268267
artifacts:
269268
paths:
270269
- build_child_pipeline.yml

.gitlab/ci/pre_check.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,3 @@ pipeline_variables:
166166
- pipeline.env
167167
expire_in: 1 week
168168
when: always
169-
170-
check_test_cases_env_markers_and_required_runners:
171-
extends:
172-
- .pre_check_template
173-
tags: [fast_run, shiny]
174-
script:
175-
- python tools/ci/dynamic_pipelines/scripts/generate_target_test_child_pipeline.py --check

tools/ci/dynamic_pipelines/scripts/generate_target_test_child_pipeline.py

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@
2828
from gitlab.v4.objects import Project
2929
from gitlab_api import Gitlab
3030
from idf_build_apps import App
31-
from idf_build_apps.constants import BuildStatus
3231
from idf_ci.app import import_apps_from_txt
33-
from idf_pytest.script import get_all_apps
3432
from idf_pytest.script import get_pytest_cases
3533

3634

@@ -187,13 +185,6 @@ def generate_target_test_child_pipeline(
187185
default=DEFAULT_TARGET_TEST_CHILD_PIPELINE_FILEPATH,
188186
help='Output child pipeline file path',
189187
)
190-
parser.add_argument(
191-
'--check',
192-
action='store_true',
193-
help='Check if the child pipeline could be generated successfully. '
194-
'test cases without env marker or required unset runner will be printed out. '
195-
'(Note: All apps and test cases will be checked)',
196-
)
197188
parser.add_argument(
198189
'--app-info-filepattern',
199190
default='list_job_*.txt',
@@ -206,14 +197,9 @@ def generate_target_test_child_pipeline(
206197

207198
gl_project = Gitlab(args.project_id).project
208199

209-
if args.check:
210-
apps = list(get_all_apps(args.paths)[0]) # test related apps only
211-
for app in apps:
212-
app.build_status = BuildStatus.SUCCESS # pretend they are built successfully
213-
else:
214-
apps = []
215-
for f in glob.glob(args.app_info_filepattern):
216-
apps.extend(import_apps_from_txt(f))
200+
apps = []
201+
for f in glob.glob(args.app_info_filepattern):
202+
apps.extend(import_apps_from_txt(f))
217203

218204
generate_target_test_child_pipeline(
219205
gl_project,

0 commit comments

Comments
 (0)