Skip to content

Commit e6815fd

Browse files
committed
Merge branch 'bugfix/storage_generic_pytests_v5.4' into 'release/v5.4'
fix(ci): Removed storage related entries in known generate test child pipeline warnings (v5.4) See merge request espressif/esp-idf!36683
2 parents c3044ca + b02cb7d commit e6815fd

File tree

9 files changed

+19
-18
lines changed

9 files changed

+19
-18
lines changed

components/nvs_flash/test_apps/pytest_nvs_flash.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
@pytest.mark.esp32
1313
@pytest.mark.esp32c3
14+
@pytest.mark.generic
1415
@pytest.mark.parametrize('config', ['default'], indirect=True)
1516
def test_nvs_flash(dut: IdfDut) -> None:
1617
dut.run_all_single_board_cases(group='!nvs_encr_hmac', timeout=120)

components/vfs/test_apps/pytest_vfs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
@pytest.mark.esp32c3
99
@pytest.mark.esp32c6
1010
@pytest.mark.esp32h2
11+
@pytest.mark.generic
1112
@pytest.mark.parametrize('config', [
1213
'default', 'iram',
1314
], indirect=True)
@@ -16,6 +17,7 @@ def test_vfs_default(dut: Dut) -> None:
1617

1718

1819
@pytest.mark.esp32
20+
@pytest.mark.generic
1921
@pytest.mark.parametrize('config', [
2022
'ccomp',
2123
], indirect=True)

components/vfs/test_apps/sdkconfig.defaults

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,5 @@ CONFIG_PARTITION_TABLE_CUSTOM=y
77
CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"
88

99
CONFIG_ESP_TASK_WDT_INIT=n
10+
11+
CONFIG_VFS_MAX_COUNT=10

examples/storage/nvs_rw_blob/pytest_nvs_rw_blob.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
22
# SPDX-License-Identifier: Unlicense OR CC0-1.0
3-
43
import logging
54
import random
65
import re
@@ -13,6 +12,7 @@
1312

1413
@pytest.mark.esp32
1514
@pytest.mark.esp32c3
15+
@pytest.mark.generic
1616
def test_examples_nvs_rw_blob(dut: Dut) -> None:
1717
def expect_start_msg(index: int) -> None:
1818
dut.expect('Restart counter = {}'.format(index), timeout=10)

examples/storage/nvs_rw_value/pytest_nvs_rw_value.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
22
# SPDX-License-Identifier: Unlicense OR CC0-1.0
3-
43
import logging
54
from itertools import zip_longest
65

@@ -10,11 +9,14 @@
109

1110
@pytest.mark.esp32
1211
@pytest.mark.esp32c3
12+
@pytest.mark.generic
1313
def test_examples_nvs_rw_value(dut: Dut) -> None:
14+
dut.serial.erase_flash()
15+
dut.serial.flash()
1416
for i, counter_state in zip_longest(range(4), ('The value is not initialized yet!',), fillvalue='Done'):
1517
dut.expect('Opening Non-Volatile Storage \\(NVS\\) handle... Done', timeout=20)
1618
dut.expect('Reading restart counter from NVS ... {}'.format(counter_state), timeout=20)
17-
dut.expect('Restart counter = {}'.format(i) if i > 0 else '', timeout=20)
19+
dut.expect('Restart counter = {}'.format(i) if int(i) > 0 else '', timeout=20)
1820
dut.expect('Updating restart counter in NVS ... Done', timeout=20)
1921
dut.expect('Committing updates in NVS ... Done', timeout=20)
2022
dut.expect('Restarting in 10 seconds...', timeout=20)

examples/storage/nvs_rw_value_cxx/pytest_nvs_rw_value_cxx.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
22
# SPDX-License-Identifier: Unlicense OR CC0-1.0
3-
43
import logging
54
from itertools import zip_longest
65

@@ -10,11 +9,14 @@
109

1110
@pytest.mark.esp32
1211
@pytest.mark.esp32c3
12+
@pytest.mark.generic
1313
def test_examples_nvs_rw_value_cxx(dut: Dut) -> None:
14+
dut.serial.erase_flash()
15+
dut.serial.flash()
1416
for i, counter_state in zip_longest(range(4), ('The value is not initialized yet!',), fillvalue='Done'):
1517
dut.expect('Opening Non-Volatile Storage \\(NVS\\) handle... Done', timeout=20)
1618
dut.expect('Reading restart counter from NVS ... {}'.format(counter_state), timeout=20)
17-
dut.expect('Restart counter = {}'.format(i) if i > 0 else '', timeout=20)
19+
dut.expect('Restart counter = {}'.format(i) if int(i) > 0 else '', timeout=20)
1820
dut.expect('Updating restart counter in NVS ... Done', timeout=20)
1921
dut.expect('Committing updates in NVS ... Done', timeout=20)
2022
dut.expect('Restarting in 10 seconds...', timeout=20)

examples/storage/wear_levelling/main/wear_levelling_example_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ void app_main(void)
106106
ESP_LOGI(TAG, "file still exists");
107107
return;
108108
} else {
109-
ESP_LOGI(TAG, "file doesnt exist, format done");
109+
ESP_LOGI(TAG, "file does not exist, format done");
110110
}
111111

112112
//Create file and write

examples/storage/wear_levelling/pytest_wear_levelling_example.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
1+
# SPDX-FileCopyrightText: 2022-2024 Espressif Systems (Shanghai) CO LTD
22
# SPDX-License-Identifier: Unlicense OR CC0-1.0
3-
4-
53
import re
64

75
import pytest
@@ -10,6 +8,7 @@
108

119
@pytest.mark.esp32
1210
@pytest.mark.esp32c3
11+
@pytest.mark.generic
1312
def test_wear_levelling_example(dut: Dut) -> None:
1413

1514
message_list = ('example: Mounting FAT filesystem',
@@ -18,7 +17,7 @@ def test_wear_levelling_example(dut: Dut) -> None:
1817
'example: Reading file',
1918
re.compile(str.encode('example: Read from file: \'hello world, from ESP-IDF \\S+\'')),
2019
re.compile(str.encode('vfs_fat_spiflash: Formatting FATFS partition, allocation unit size=\\S+')),
21-
'example: file doesnt exist, format done',
20+
'example: file does not exist, format done',
2221
'example: Opening file',
2322
'example: File written',
2423
'example: Reading file',

tools/ci/dynamic_pipelines/templates/known_generate_test_child_pipeline_warnings.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,7 @@
22
# no_env_marker_test_cases: List of test cases that do not have environment markers.
33
# each item shall be the test node id, you may check the error message to get the node id.
44
no_env_marker_test_cases:
5-
- components/nvs_flash/test_apps/pytest_nvs_flash.py::test_nvs_flash[default]
6-
- components/vfs/test_apps/pytest_vfs.py::test_vfs_ccomp[ccomp]
7-
- components/vfs/test_apps/pytest_vfs.py::test_vfs_default[default]
8-
- components/vfs/test_apps/pytest_vfs.py::test_vfs_default[iram]
9-
- examples/storage/nvs_rw_blob/pytest_nvs_rw_blob.py::test_examples_nvs_rw_blob
10-
- examples/storage/nvs_rw_value/pytest_nvs_rw_value.py::test_examples_nvs_rw_value
11-
- examples/storage/nvs_rw_value_cxx/pytest_nvs_rw_value_cxx.py::test_examples_nvs_rw_value_cxx
12-
- examples/storage/wear_levelling/pytest_wear_levelling_example.py::test_wear_levelling_example
5+
- dummy_test_case
136

147
# no_runner_tags: List of runner tags that has no test runner set.
158
# each item shall be a comma separated list of runner tags.

0 commit comments

Comments
 (0)