Skip to content

Commit 1312472

Browse files
L-KAYAespressif-bot
authored andcommitted
fix(i2s): fixed i2s_std initializer order for cpp compiler
Closes espressif#15405
1 parent a043a96 commit 1312472

File tree

4 files changed

+65
-3
lines changed

4 files changed

+65
-3
lines changed

components/esp_driver_i2s/include/driver/i2s_pdm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
2+
* SPDX-FileCopyrightText: 2022-2025 Espressif Systems (Shanghai) CO LTD
33
*
44
* SPDX-License-Identifier: Apache-2.0
55
*/

components/esp_driver_i2s/include/driver/i2s_std.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,8 @@ extern "C" {
215215
#define I2S_STD_CLK_DEFAULT_CONFIG(rate) { \
216216
.sample_rate_hz = rate, \
217217
.clk_src = I2S_CLK_SRC_DEFAULT, \
218-
.mclk_multiple = I2S_MCLK_MULTIPLE_256, \
219218
.ext_clk_freq_hz = 0, \
219+
.mclk_multiple = I2S_MCLK_MULTIPLE_256, \
220220
}
221221
#endif
222222

tools/test_apps/system/cxx_build_test/main/CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,15 @@ if(CONFIG_SOC_I2C_SUPPORTED)
77
list(APPEND srcs test_i2c_lcd.cpp)
88
endif()
99

10+
if(CONFIG_SOC_I2S_SUPPORTED)
11+
list(APPEND srcs test_i2s.cpp)
12+
endif()
13+
1014
if(CONFIG_SOC_TWAI_SUPPORTED)
1115
list(APPEND srcs test_twai.cpp)
1216
endif()
1317

1418
idf_component_register(SRCS "${srcs}"
1519
INCLUDE_DIRS "."
16-
PRIV_REQUIRES driver esp_lcd
20+
PRIV_REQUIRES driver esp_lcd esp_driver_i2s
1721
REQUIRES soc)
Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
/*
2+
* SPDX-FileCopyrightText: 2025 Espressif Systems (Shanghai) CO LTD
3+
*
4+
* SPDX-License-Identifier: Apache-2.0
5+
*/
6+
#include "soc/soc_caps.h"
7+
#include "driver/i2s_std.h"
8+
#if SOC_I2S_SUPPORTS_TDM
9+
#include "driver/i2s_tdm.h"
10+
#endif
11+
#if SOC_I2S_SUPPORTS_PDM
12+
#include "driver/i2s_pdm.h"
13+
#endif
14+
15+
/**
16+
* Check that C-style designated initializers are valid in C++ file.
17+
*/
18+
void test_i2s_initializers(void)
19+
{
20+
i2s_std_clk_config_t std_clk_cfg = I2S_STD_CLK_DEFAULT_CONFIG(16000);
21+
i2s_std_slot_config_t std_philips_slot_cfg = I2S_STD_PHILIPS_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO);
22+
i2s_std_slot_config_t std_msb_slot_cfg = I2S_STD_MSB_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO);
23+
i2s_std_slot_config_t std_pcm_slot_cfg = I2S_STD_PCM_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO);
24+
(void) std_clk_cfg;
25+
(void) std_philips_slot_cfg;
26+
(void) std_msb_slot_cfg;
27+
(void) std_pcm_slot_cfg;
28+
#if SOC_I2S_SUPPORTS_TDM
29+
i2s_tdm_clk_config_t tdm_clk_cfg = I2S_TDM_CLK_DEFAULT_CONFIG(16000);
30+
i2s_tdm_slot_config_t tdm_philips_slot_cfg = I2S_TDM_PHILIPS_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO, (i2s_tdm_slot_mask_t)0x03);
31+
i2s_tdm_slot_config_t tdm_msb_slot_cfg = I2S_TDM_MSB_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO, (i2s_tdm_slot_mask_t)0x03);
32+
i2s_tdm_slot_config_t tdm_pcm_s_slot_cfg = I2S_TDM_PCM_SHORT_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO, (i2s_tdm_slot_mask_t)0x03);
33+
i2s_tdm_slot_config_t tdm_pcm_l_slot_cfg = I2S_TDM_PCM_LONG_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO, (i2s_tdm_slot_mask_t)0x03);
34+
(void) tdm_clk_cfg;
35+
(void) tdm_philips_slot_cfg;
36+
(void) tdm_msb_slot_cfg;
37+
(void) tdm_pcm_s_slot_cfg;
38+
(void) tdm_pcm_l_slot_cfg;
39+
#endif
40+
#if SOC_I2S_SUPPORTS_PDM_RX
41+
i2s_pdm_rx_clk_config_t pdm_rx_clk_cfg = I2S_PDM_RX_CLK_DEFAULT_CONFIG(16000);
42+
i2s_pdm_rx_slot_config_t pdm_rx_pcm_slot_cfg = I2S_PDM_RX_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO);
43+
(void) pdm_rx_clk_cfg;
44+
(void) pdm_rx_pcm_slot_cfg;
45+
#endif
46+
#if SOC_I2S_SUPPORTS_PDM_TX
47+
i2s_pdm_tx_clk_config_t pdm_tx_clk_cfg = I2S_PDM_TX_CLK_DEFAULT_CONFIG(16000);
48+
i2s_pdm_tx_clk_config_t pdm_tx_dac_clk_cfg = I2S_PDM_TX_CLK_DAC_DEFAULT_CONFIG(16000);
49+
i2s_pdm_tx_slot_config_t pdm_tx_pcm_slot_cfg = I2S_PDM_TX_SLOT_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO);
50+
(void) pdm_tx_clk_cfg;
51+
(void) pdm_tx_dac_clk_cfg;
52+
(void) pdm_tx_pcm_slot_cfg;
53+
#if SOC_I2S_HW_VERSION_2
54+
i2s_pdm_tx_slot_config_t pdm_tx_pcm_dac_slot_cfg = I2S_PDM_TX_SLOT_DAC_DEFAULT_CONFIG(I2S_DATA_BIT_WIDTH_16BIT, I2S_SLOT_MODE_STEREO);
55+
(void) pdm_tx_pcm_dac_slot_cfg;
56+
#endif
57+
#endif
58+
}

0 commit comments

Comments
 (0)