Don't log collector errors (prometheus-community#1050)

SuperQ · pincher95 · commit 7acfdfc22c3d · 2025-11-26T09:41:39.000-05:00
Avoid logging collector failures at Error level to avoid log spam.

Signed-off-by: SuperQ &lt;superq@gmail.com&gt;
Signed-off-by: pincher95 &lt;yuri.tsuprun@logz.io&gt;
diff --git a/collector/collector.go b/collector/collector.go
@@ -185,7 +185,7 @@ func execute(ctx context.Context, name string, c Collector, ch chan<- prometheus
 		if IsNoDataError(err) {
 			logger.Debug("collector returned no data", "name", name, "duration_seconds", duration.Seconds(), "err", err)
 		} else {
-			logger.Error("collector failed", "name", name, "duration_seconds", duration.Seconds(), "err", err)
+			logger.Warn("collector failed", "name", name, "duration_seconds", duration.Seconds(), "err", err)
 		}
 		success = 0
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ func execute(ctx context.Context, name string, c Collector, ch chan<- prometheus`
`185`	`185`	`if IsNoDataError(err) {`
`186`	`186`	`logger.Debug("collector returned no data", "name", name, "duration_seconds", duration.Seconds(), "err", err)`
`187`	`187`	`} else {`
`188`		`- logger.Error("collector failed", "name", name, "duration_seconds", duration.Seconds(), "err", err)`
	`188`	`+ logger.Warn("collector failed", "name", name, "duration_seconds", duration.Seconds(), "err", err)`
`189`	`189`	`}`
`190`	`190`	`success = 0`
`191`	`191`	`} else {`