chore: new clippy warnings dropped

I fix clippy warnings
 ^
 |     T_T     |
               v
they add new ones

Author: gmoshkin

tarantool/src/datetime.rs

@@ -122,7 +122,7 @@ impl Display for Datetime {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
-/// Tuple
+// Tuple
 ////////////////////////////////////////////////////////////////////////////////
 
 impl serde::Serialize for Datetime {
@@ -173,7 +173,7 @@ impl<'de> serde::Deserialize<'de> for Datetime {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
-/// Lua
+// Lua
 ////////////////////////////////////////////////////////////////////////////////
 
 static CTID_DATETIME: Lazy<u32> = Lazy::new(|| {

tarantool/src/ffi/tarantool.rs

@@ -37,19 +37,15 @@ extern "C" {
     /// Wait until **READ** or **WRITE** event on socket (`fd`). Yields.
     /// - `fd` - non-blocking socket file description
     /// - `events` - requested events to wait.
-    /// Combination of `TNT_IO_READ` | `TNT_IO_WRITE` bit flags.
+    ///   Combination of `TNT_IO_READ` | `TNT_IO_WRITE` bit flags.
     /// - `timeout` - timeout in seconds.
     ///
     /// Returns:
     /// - `0` - timeout
-    /// - `>0` - returned events. Combination of `TNT_IO_READ` | `TNT_IO_WRITE`
-    /// bit flags.
+    /// - `>0` - returned events. Combination of `TNT_IO_READ` | `TNT_IO_WRITE` bit flags.
     pub fn coio_wait(fd: c_int, event: c_int, timeout: f64) -> c_int;
 
-    /**
-     * Close the fd and wake any fiber blocked in
-     * coio_wait() call on this fd.
-     */
+    /// Close the fd and wake any fiber blocked in coio_wait() call on this fd.
     pub fn coio_close(fd: c_int) -> c_int;
 
     /// Fiber-friendly version of getaddrinfo(3).
@@ -63,8 +59,8 @@ extern "C" {
     /// Returns:
     /// -  `0` on success, please free @a res using freeaddrinfo(3).
     /// - `-1` on error, check diag.
-    ///            Please note that the return value is not compatible with
-    ///            getaddrinfo(3).
+    ///
+    /// > Please note that the return value is not compatible with getaddrinfo(3).
     pub fn coio_getaddrinfo(
         host: *const c_char,
         port: *const c_char,

tarantool/src/fiber.rs

@@ -3,7 +3,7 @@
 //! With the fiber module, you can:
 //! - create, run and manage [fibers](Builder),
 //! - use a synchronization mechanism for fibers, similar to “condition variables” and similar to operating-system
-//! functions such as `pthread_cond_wait()` plus `pthread_cond_signal()`,
+//!   functions such as `pthread_cond_wait()` plus `pthread_cond_signal()`,
 //! - spawn a fiber based [async runtime](async).
 //!
 //! See also:
@@ -110,14 +110,14 @@ pub struct Fiber<'a, T: 'a> {
 }
 
 #[allow(deprecated)]
-impl<'a, T> ::std::fmt::Debug for Fiber<'a, T> {
+impl<T> ::std::fmt::Debug for Fiber<'_, T> {
     fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
         f.debug_struct("Fiber").finish_non_exhaustive()
     }
 }
 
 #[allow(deprecated)]
-impl<'a, T> Fiber<'a, T> {
+impl<T> Fiber<'_, T> {
     /// Create a new fiber.
     ///
     /// Takes a fiber from fiber cache, if it's not empty. Can fail only if there is not enough memory for
@@ -1049,7 +1049,7 @@ pub struct JoinHandle<'f, T> {
     marker: PhantomData<&'f ()>,
 }
 
-impl<'f, T> std::fmt::Debug for JoinHandle<'f, T> {
+impl<T> std::fmt::Debug for JoinHandle<'_, T> {
     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
         f.debug_struct("JoinHandle").finish_non_exhaustive()
     }
@@ -1082,7 +1082,7 @@ enum JoinHandleImpl<T> {
 
 type FiberResultCell<T> = Box<UnsafeCell<Option<T>>>;
 
-impl<'f, T> JoinHandle<'f, T> {
+impl<T> JoinHandle<'_, T> {
     #[inline(always)]
     fn ffi(fiber: NonNull<ffi::Fiber>, result_cell: Option<FiberResultCell<T>>) -> Self {
         Self {
@@ -1253,7 +1253,7 @@ impl<'f, T> JoinHandle<'f, T> {
     }
 }
 
-impl<'f, T> Drop for JoinHandle<'f, T> {
+impl<T> Drop for JoinHandle<'_, T> {
     fn drop(&mut self) {
         if let Some(mut inner) = self.inner.take() {
             if let JoinHandleImpl::Ffi { result_cell, .. } = &mut inner {

tarantool/src/fiber/async/mutex.rs

@@ -191,7 +191,7 @@ impl<T> From<T> for Mutex<T> {
     }
 }
 
-impl<T: ?Sized + Default> Default for Mutex<T> {
+impl<T: Default> Default for Mutex<T> {
     /// Creates a `Mutex<T>`, with the `Default` value for T.
     fn default() -> Mutex<T> {
         Mutex::new(Default::default())

tarantool/src/fiber/async/watch.rs

@@ -204,7 +204,7 @@ impl<T> Drop for Sender<T> {
 /// to keep the borrow as short lived as possible.
 pub struct ValueRef<'a, T>(Ref<'a, Value<T>>);
 
-impl<'a, T> Deref for ValueRef<'a, T> {
+impl<T> Deref for ValueRef<'_, T> {
     type Target = T;
 
     fn deref(&self) -> &Self::Target {
@@ -312,7 +312,7 @@ impl<T> Clone for Receiver<T> {
     }
 }
 
-impl<'a, T> Future for Notification<'a, T> {
+impl<T> Future for Notification<'_, T> {
     type Output = Result<(), RecvError>;
 
     fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {

tarantool/src/fiber/mutex.rs

@@ -208,7 +208,7 @@ impl<T> From<T> for Mutex<T> {
     }
 }
 
-impl<T: ?Sized + Default> Default for Mutex<T> {
+impl<T: Default> Default for Mutex<T> {
     /// Creates a `Mutex<T>`, with the `Default` value for T.
     fn default() -> Mutex<T> {
         Mutex::new(Default::default())

tarantool/src/lib.rs

@@ -8,6 +8,7 @@
 #![allow(clippy::needless_late_init)]
 #![allow(clippy::bool_assert_comparison)]
 #![allow(clippy::field_reassign_with_default)]
+#![allow(clippy::manual_unwrap_or)]
 #![allow(rustdoc::redundant_explicit_links)]
 //! Tarantool C API bindings for Rust.
 //! This library contains the following Tarantool API's:
@@ -229,7 +230,7 @@ pub mod vclock;
 /// [`Display`]), the return values read as follows:
 /// - `Ok(v)`: the stored procedure will return `v`
 /// - `Err(e)`: the stored procedure will fail and `e` will be set as the last
-/// Tarantool error (see also [`TarantoolError::last`])
+///   Tarantool error (see also [`TarantoolError::last`])
 /// ```no_run
 /// use tarantool::{error::Error, index::IteratorType::Eq, space::Space};
 ///

tarantool/src/msgpack.rs

@@ -906,6 +906,7 @@ mod test {
 }
 
 #[cfg(feature = "internal_test")]
+#[allow(clippy::disallowed_names)]
 mod tests {
     use super::*;
     use pretty_assertions::assert_eq;

tarantool/src/msgpack/encode.rs

@@ -398,9 +398,9 @@ where
     }
 }
 
-impl<'a, 'de, T> Decode<'de> for Cow<'a, T>
+impl<'de, T> Decode<'de> for Cow<'_, T>
 where
-    T: Decode<'de> + ToOwned + ?Sized,
+    T: Decode<'de> + ToOwned,
 {
     // Clippy doesn't notice the type difference
     #[allow(clippy::redundant_clone)]
@@ -746,7 +746,7 @@ where
     }
 }
 
-impl<'a, T> Encode for Cow<'a, T>
+impl<T> Encode for Cow<'_, T>
 where
     T: Encode + ToOwned + ?Sized,
 {

tarantool/src/net_box/mod.rs

@@ -31,9 +31,9 @@
 //! - The state machine starts in the `initial` state.
 //! - [Conn::new()](struct.Conn.html#method.new) method changes the state to `connecting` and spawns a worker fiber.
 //! - If authentication and schema upload are required, it’s possible later on to re-enter the `fetch_schema` state
-//! from `active` if a request fails due to a schema version mismatch error, so schema reload is triggered.
+//!   from `active` if a request fails due to a schema version mismatch error, so schema reload is triggered.
 //! - [conn.close()](struct.Conn.html#method.close) method sets the state to `closed` and kills the worker. If the
-//! transport is already in the `error` state, [close()](struct.Conn.html#method.close) does nothing.
+//!   transport is already in the `error` state, [close()](struct.Conn.html#method.close) does nothing.
 //!
 //! See also:
 //! - [Lua reference: Module net.box](https://www.tarantool.io/en/doc/latest/reference/reference_lua/net_box/)