Fix "Named arguments are supported only on PHP 8.0 and later." false positive

Author: staabm

.github/workflows/e2e-tests.yml

@@ -391,6 +391,9 @@ jobs:
               cd e2e/composer-version-config
               composer install
               ../../bin/phpstan analyze test.php --level=0
+          - script: |
+              cd e2e/composer-version-named-args
+              ../../bin/phpstan analyze test.php --level=0
 
     steps:
       - name: "Checkout"

e2e/composer-version-named-args/test.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types=1);
+
+namespace NamedAttributesPhpversion;
+
+use Exception;
+use function PHPStan\debugScope;
+use function PHPStan\dumpType;
+use function PHPStan\Testing\assertType;
+
+class HelloWorld
+{
+	/** @return mixed[] */
+	public function sayHello(): array|null
+	{
+		if(PHP_VERSION_ID >= 80400) {
+		} else {
+		}
+		return [
+			new Exception(previous: new Exception()),
+		];
+	}
+}
+
+class HelloWorld2
+{
+	/** @return mixed[] */
+	public function sayHello(): array|null
+	{
+		return [
+			PHP_VERSION_ID >= 80400 ? 1 : 0,
+			new Exception(previous: new Exception()),
+		];
+	}
+}

src/Analyser/ConstantResolver.php

@@ -34,6 +34,8 @@
 final class ConstantResolver
 {
 
+	public const PHP_MIN_ANALYZABLE_VERSION_ID = 50207;
+
 	/** @var array<string, true> */
 	private array $currentlyResolving = [];
 
@@ -141,7 +143,7 @@ public function resolvePredefinedConstant(string $resolvedConstantName): ?Type
 			return $this->createInteger($minRelease, $maxRelease);
 		}
 		if ($resolvedConstantName === 'PHP_VERSION_ID') {
-			$minVersion = 50207;
+			$minVersion = self::PHP_MIN_ANALYZABLE_VERSION_ID;
 			$maxVersion = null;
 			if ($minPhpVersion !== null) {
 				$minVersion = max($minVersion, $minPhpVersion->getVersionId());

src/Analyser/MutatingScope.php

@@ -52,6 +52,7 @@
 use PHPStan\Parser\NewAssignedToPropertyVisitor;
 use PHPStan\Parser\Parser;
 use PHPStan\Php\PhpVersion;
+use PHPStan\Php\PhpVersionFactory;
 use PHPStan\Php\PhpVersions;
 use PHPStan\PhpDoc\Tag\TemplateTag;
 use PHPStan\Reflection\Assertions;
@@ -6235,8 +6236,10 @@ public function getIterableValueType(Type $iteratee): Type
 
 	public function getPhpVersion(): PhpVersions
 	{
+		$overallPhpVersionRange = IntegerRangeType::fromInterval(ConstantResolver::PHP_MIN_ANALYZABLE_VERSION_ID, PhpVersionFactory::MAX_PHP_VERSION);
+
 		$constType = $this->getGlobalConstantType(new Name('PHP_VERSION_ID'));
-		if ($constType !== null) {
+		if ($constType !== null && !$constType->equals($overallPhpVersionRange)) {
 			return new PhpVersions($constType);
 		}