Add non-regression test

Author: VincentLanglet

tests/PHPStan/Analyser/nsrt/bug-8592.php

@@ -0,0 +1,15 @@
+<?php declare(strict_types = 1);
+
+namespace Bug8592;
+
+use function PHPStan\Testing\assertType;
+
+/**
+ * @param array<numeric-string, mixed> $foo
+ */
+function foo(array $foo): void
+{
+	foreach ($foo as $key => $value) {
+		assertType('int|numeric-string', $key);
+	}
+}

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -898,6 +898,11 @@ public function testBug2634(): void
 		$this->analyse([__DIR__ . '/data/bug-2634.php'], []);
 	}
 
+	public function testBug11390(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11390.php'], []);
+	}
+
 	public function testInternalClassesWithOverloadedOffsetAccess(): void
 	{
 		$this->analyse([__DIR__ . '/data/internal-classes-overload-offset-access.php'], []);

tests/PHPStan/Rules/Arrays/data/bug-11390.php

@@ -0,0 +1,27 @@
+<?php declare(strict_types = 1);
+
+namespace Bug11390;
+
+/**
+ * @param array<array{
+ *   id: numeric-string,
+ *   tagName: string
+ * }> $tags
+ * @param numeric-string $tagId
+ */
+function printTagName(array $tags, string $tagId): void
+{
+	// Adding the second `*` to either of the following lines makes the error disappear
+
+	$tagsById = array_combine(array_column($tags, 'id'), $tags);
+	echo $tagsById[$tagId]['tagName'] . PHP_EOL;
+}
+
+printTagName(
+	[
+		['id' => '123', 'tagName' => 'abc'],
+		['id' => '4.5', 'tagName' => 'def'],
+		['id' => '6e78', 'tagName' => 'ghi']
+	],
+	'4.5'
+);