fix

Author: staabm

src/Rules/Variables/UnsetRule.php

@@ -75,20 +75,6 @@ private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError
 		) {
 			$type = $scope->getType($node->var);
 			foreach ($type->getObjectClassReflections() as $classReflection) {
-				if ($classReflection->isReadOnly() || $classReflection->isImmutable()) {
-					return RuleErrorBuilder::message(
-						sprintf(
-							'Cannot unset property %s of %s class %s.',
-							$node->name->name,
-							$classReflection->isReadOnly() ? 'readonly' : 'immutable',
-							$type->describe(VerbosityLevel::value()),
-						),
-					)
-						->line($node->getStartLine())
-						->identifier('unset.readonlyClass')
-						->build();
-				}
-
 				if (!$classReflection->hasNativeProperty($node->name->name)) {
 					continue;
 				}
@@ -104,7 +90,7 @@ private function canBeUnset(Node $node, Scope $scope): ?IdentifierRuleError
 						),
 					)
 						->line($node->getStartLine())
-						->identifier('unset.readonlyProperty')
+						->identifier($propertyReflection->isReadOnly() ? 'unset.readOnlyProperty' : 'unset.readOnlyPropertyByPhpDoc')
 						->build();
 				}
 			}

tests/PHPStan/Rules/Variables/UnsetRuleTest.php

@@ -95,23 +95,23 @@ public function testBug12421(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-12421.php'], [
 			[
-				'Cannot unset property y of readonly class Bug12421\NativeReadonlyClass.',
+				'Cannot unset readonly property y of Bug12421\NativeReadonlyClass.',
 				11,
 			],
 			[
 				'Cannot unset readonly property y of Bug12421\NativeReadonlyProperty.',
 				15,
 			],
 			[
-				'Cannot unset property y of immutable class Bug12421\PhpdocReadonlyClass.',
+				'Cannot unset @readonly property y of Bug12421\PhpdocReadonlyClass.',
 				19,
 			],
 			[
 				'Cannot unset @readonly property y of Bug12421\PhpdocReadonlyProperty.',
 				23,
 			],
 			[
-				'Cannot unset property y of immutable class Bug12421\PhpdocImmutableClass.',
+				'Cannot unset @readonly property y of Bug12421\PhpdocImmutableClass.',
 				27,
 			],
 			[