Added regression test

Author: staabm

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -1016,4 +1016,9 @@ public function testBug11019(): void
 		$this->analyse([__DIR__ . '/data/bug-11019.php'], []);
 	}
 
+	public function testBug12946(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12946.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-12946.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Bug12946;
+
+interface UserInterface {}
+class User implements UserInterface{}
+
+class UserMapper {
+	function getFromId(int $id) : ?UserInterface {
+		return $id === 10 ? new User : null;
+	}
+}
+
+class GetUserCommand {
+
+	private ?UserInterface $currentUser = null;
+
+	public function __construct(
+		private readonly UserMapper $userMapper,
+		private readonly int $id,
+	) {
+	}
+
+	public function __invoke() : UserInterface {
+		if( $this->currentUser ) {
+			return $this->currentUser;
+		}
+
+		$this->currentUser = $this->userMapper->getFromId($this->id);
+		if( $this->currentUser === null ) {
+			throw new \Exception;
+		}
+
+		return $this->currentUser;
+	}
+
+}