works only on instance methods

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -5711,15 +5711,8 @@ static function (): void {
 						$assignedNativeType = $scope->getNativeType($assignedExpr);
 						$propertyNativeType = $propertyReflection->getNativeType();
 
-						$newAssignedType = TypeCombinator::intersect($assignedExprType, $propertyNativeType);
-						if ($newAssignedType instanceof NeverType) {
-							$newAssignedType = TypeCombinator::intersect($assignedExprType->toCoercedArgumentType(true), $propertyNativeType);
-						}
-
-						$newAssignedNativeType = TypeCombinator::intersect($assignedNativeType, $propertyNativeType);
-						if ($newAssignedNativeType instanceof NeverType) {
-							$newAssignedNativeType = TypeCombinator::intersect($assignedNativeType->toCoercedArgumentType(true), $propertyNativeType);
-						}
+						$newAssignedType = TypeCombinator::intersect($assignedExprType->toCoercedArgumentType(true), $propertyNativeType);
+						$newAssignedNativeType = TypeCombinator::intersect($assignedNativeType->toCoercedArgumentType(true), $propertyNativeType);
 
 						$scope = $scope->assignExpression($var, $newAssignedType, $newAssignedNativeType);
 					} else {

tests/PHPStan/Analyser/nsrt/bug-12902.php

@@ -5,7 +5,7 @@
 use function PHPStan\Testing\assertNativeType;
 use function PHPStan\Testing\assertType;
 
-class NarrowsNativeUnion {
+class NarrowsNativeReadonlyUnion {
 	private readonly int|float $i;
 
 	public function __construct()
@@ -21,17 +21,39 @@ public function doFoo(): void {
 	}
 }
 
+class NarrowsNativeUnion {
+	private int|float $i;
+
+	public function __construct()
+	{
+		$this->i = getInt();
+		assertType('int', $this->i);
+		assertNativeType('int', $this->i);
+
+		$this->impureCall();;
+		assertType('float|int', $this->i);
+		assertNativeType('float|int', $this->i);
+	}
+
+	public function doFoo(): void {
+		assertType('float|int', $this->i);
+		assertNativeType('float|int', $this->i);
+	}
+
+	/** @phpstan-impure  */
+	public function impureCall(): void {}
+}
+
 class NarrowsStaticNativeUnion {
 	private static int|float $i;
 
 	public function __construct()
 	{
 		self::$i = getInt();
-		assertType('int', self::$i);
-		assertNativeType('int', self::$i);
+		assertType('float|int', self::$i); // could be int
+		assertNativeType('float|int', self::$i); // could be int
 
 		$this->impureCall();
-
 		assertType('float|int', self::$i);
 		assertNativeType('float|int', self::$i);
 	}