fix bools

Author: staabm

src/Type/BooleanType.php

@@ -113,6 +113,10 @@ public function toArrayKey(): Type
 
 	public function toCoercedArgumentType(bool $strictTypes): Type
 	{
+		if (!$strictTypes) {
+			return TypeCombinator::union(new IntegerType(), new FloatType(), new StringType(), new BooleanType());
+		}
+
 		return $this;
 	}
 

src/Type/Constant/ConstantBooleanType.php

@@ -8,12 +8,16 @@
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\ConstantScalarType;
+use PHPStan\Type\FloatType;
 use PHPStan\Type\GeneralizePrecision;
+use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\StaticTypeFactory;
+use PHPStan\Type\StringType;
 use PHPStan\Type\Traits\ConstantScalarTypeTrait;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\VerbosityLevel;
 
 /** @api */
@@ -109,6 +113,10 @@ public function toArrayKey(): Type
 
 	public function toCoercedArgumentType(bool $strictTypes): Type
 	{
+		if (!$strictTypes) {
+			return TypeCombinator::union(new IntegerType(), new FloatType(), new StringType(), new BooleanType());
+		}
+
 		return $this;
 	}
 

src/Type/Constant/ConstantIntegerType.php

@@ -5,13 +5,15 @@
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprIntegerNode;
 use PHPStan\PhpDocParser\Ast\Type\ConstTypeNode;
 use PHPStan\PhpDocParser\Ast\Type\TypeNode;
+use PHPStan\Type\BooleanType;
 use PHPStan\Type\CompoundType;
 use PHPStan\Type\ConstantScalarType;
 use PHPStan\Type\FloatType;
 use PHPStan\Type\GeneralizePrecision;
 use PHPStan\Type\IntegerRangeType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\IsSuperTypeOfResult;
+use PHPStan\Type\StringType;
 use PHPStan\Type\Traits\ConstantNumericComparisonTypeTrait;
 use PHPStan\Type\Traits\ConstantScalarTypeTrait;
 use PHPStan\Type\Type;
@@ -97,8 +99,9 @@ public function toArrayKey(): Type
 	public function toCoercedArgumentType(bool $strictTypes): Type
 	{
 		if (!$strictTypes) {
-			return TypeCombinator::union($this, new FloatType());
+			return TypeCombinator::union(new IntegerType(), new FloatType(), new StringType(), new BooleanType());
 		}
+
 		return TypeCombinator::union($this, $this->toFloat());
 	}
 

src/Type/IntegerType.php

@@ -100,6 +100,10 @@ public function toArrayKey(): Type
 
 	public function toCoercedArgumentType(bool $strictTypes): Type
 	{
+		if (!$strictTypes) {
+			return TypeCombinator::union(new IntegerType(), new FloatType(), new StringType(), new BooleanType());
+		}
+
 		return TypeCombinator::union($this, $this->toFloat());
 	}
 

tests/PHPStan/Analyser/nsrt/bug-12393b.php

@@ -161,3 +161,57 @@ public function doBar(): void
 		assertType('int', $this->foo);
 	}
 }
+
+class FooBool
+{
+
+	public int $foo;
+
+	public function doFoo(bool $b): void
+	{
+		$this->foo = $b;
+		assertType('int', $this->foo);
+	}
+
+	public function doBar(): void
+	{
+		$this->foo = true;
+		assertType('int', $this->foo);
+	}
+}
+
+class FooBoolString
+{
+
+	public string $foo;
+
+	public function doFoo(bool $b): void
+	{
+		$this->foo = $b;
+		assertType('string', $this->foo);
+	}
+
+	public function doBar(): void
+	{
+		$this->foo = true;
+		assertType('string', $this->foo);
+	}
+}
+
+class FooIntString
+{
+
+	public string $foo;
+
+	public function doFoo(int $b): void
+	{
+		$this->foo = $b;
+		assertType('string', $this->foo); // could be numeric-string
+	}
+
+	public function doBar(): void
+	{
+		$this->foo = 1;
+		assertType('string', $this->foo); // could be numeric-string
+	}
+}