Fix hasOffsetValueType with object

Author: VincentLanglet

src/Type/ArrayType.php

@@ -268,6 +268,9 @@ public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType
 	public function hasOffsetValueType(Type $offsetType): TrinaryLogic
 	{
 		$offsetType = $offsetType->toArrayKey();
+		if ($offsetType instanceof ErrorType) {
+			return TrinaryLogic::createNo();
+		}
 
 		if ($this->getKeyType()->isSuperTypeOf($offsetType)->no()
 			&& ($offsetType->isString()->no() || !$offsetType->isConstantScalarValue()->no())

src/Type/Constant/ConstantArrayType.php

@@ -588,6 +588,10 @@ public function hasOffsetValueType(Type $offsetType): TrinaryLogic
 
 	private function recursiveHasOffsetValueType(Type $offsetType): TrinaryLogic
 	{
+		if ($offsetType instanceof ErrorType) {
+			return TrinaryLogic::createNo();
+		}
+
 		if ($offsetType instanceof UnionType) {
 			$results = [];
 			foreach ($offsetType->getTypes() as $innerType) {

src/Type/ObjectType.php

@@ -702,7 +702,7 @@ public function toArray(): Type
 
 	public function toArrayKey(): Type
 	{
-		return $this->toString();
+		return new ErrorType();
 	}
 
 	public function toCoercedArgumentType(bool $strictTypes): Type

src/Type/Traits/ObjectTypeTrait.php

@@ -19,7 +19,6 @@
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\MixedType;
-use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 
@@ -271,7 +270,7 @@ public function toArray(): Type
 
 	public function toArrayKey(): Type
 	{
-		return new StringType();
+		return new ErrorType();
 	}
 
 	public function toCoercedArgumentType(bool $strictTypes): Type

tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php

@@ -1801,7 +1801,7 @@ public static function dataProperties(): array
 				'$this->resource',
 			],
 			[
-				'mixed',
+				'*ERROR*',
 				'$this->yetAnotherAnotherMixedParameter',
 			],
 			[

tests/PHPStan/Levels/data/stringOffsetAccess-3.json

@@ -9,9 +9,19 @@
         "line": 16,
         "ignorable": true
     },
+    {
+        "message": "Offset int|object does not exist on array{baz: 21}|array{foo: 17, bar: 19}.",
+        "line": 55,
+        "ignorable": true
+    },
     {
         "message": "Invalid array key type stdClass.",
         "line": 59,
         "ignorable": true
+    },
+    {
+        "message": "Offset stdClass does not exist on array{baz: 21}|array{foo: 17, bar: 19}.",
+        "line": 59,
+        "ignorable": true
     }
-]
+]

tests/PHPStan/Levels/data/stringOffsetAccess-7.json

@@ -9,6 +9,11 @@
         "line": 31,
         "ignorable": true
     },
+    {
+        "message": "Offset int|object might not exist on array|string.",
+        "line": 35,
+        "ignorable": true
+    },
     {
         "message": "Possibly invalid array key type int|object.",
         "line": 35,

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -193,6 +193,10 @@ public function testStrings(): void
 				'Offset 12.34 might not exist on array|string.',
 				28,
 			],
+			[
+				'Offset int|object might not exist on array|string.',
+				32,
+			],
 		]);
 	}
 
@@ -921,6 +925,20 @@ public function testBug12593(): void
 		$this->analyse([__DIR__ . '/data/bug-12593.php'], []);
 	}
 
+	public function testBugObject(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-object.php'], [
+			[
+				'Offset int|object does not exist on array{baz: 21}|array{foo: 17, bar: 19}.',
+				12,
+			],
+			[
+				'Offset object does not exist on array<string, int>.',
+				21,
+			],
+		]);
+	}
+
 	public function testBug3747(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-3747.php'], []);

tests/PHPStan/Rules/Arrays/data/bug-object.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace BugObject;
+
+class B {
+	/**
+	 * @param array{baz: 21}|array{foo: 17, bar: 19} $array
+	 * @param int|object $key
+	 */
+	public function foo($array, $key)
+	{
+		$array[$key];
+	}
+
+	/**
+	 * @param array<string, int> $array
+	 * @param object $key
+	 */
+	public function foo2($array, $key)
+	{
+		$array[$key];
+	}
+}