more tests

Author: staabm

tests/PHPStan/Rules/Variables/UnsetRuleTest.php

@@ -169,6 +169,54 @@ public function testUnsetHookedProperty(): void
 				'Cannot unset property UnsetHookedProperty\NonFinalClass::$publicProperty because it might have hooks in a subclass.',
 				13,
 			],
+			[
+				'Cannot unset property UnsetHookedProperty\ContainerClass::$finalClass because it might have hooks in a subclass.',
+				83,
+			],
+			[
+				'Cannot unset property UnsetHookedProperty\ContainerClass::$nonFinalClass because it might have hooks in a subclass.',
+				87,
+			],
+			[
+				'Cannot unset hooked UnsetHookedProperty\Foo::$iii property.',
+				89,
+			],
+			[
+				'Cannot unset property UnsetHookedProperty\ContainerClass::$foo because it might have hooks in a subclass.',
+				90,
+			],
+			[
+				'Cannot unset hooked UnsetHookedProperty\User::$name property.',
+				92,
+			],
+			[
+				'Cannot unset hooked UnsetHookedProperty\User::$fullName property.',
+				93,
+			],
+			[
+				'Cannot unset property UnsetHookedProperty\ContainerClass::$user because it might have hooks in a subclass.',
+				94,
+			],
+			[
+				'Cannot unset hooked UnsetHookedProperty\User::$name property.',
+				96,
+			],
+			[
+				'Cannot unset hooked UnsetHookedProperty\User::$name property.',
+				97,
+			],
+			[
+				'Cannot unset hooked UnsetHookedProperty\User::$fullName property.',
+				98,
+			],
+			[
+				'Cannot unset hooked UnsetHookedProperty\User::$fullName property.',
+				99,
+			],
+			[
+				'Cannot unset property UnsetHookedProperty\ContainerClass::$arrayOfUsers because it might have hooks in a subclass.',
+				100,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Variables/data/unset-hooked-property.php

@@ -65,6 +65,41 @@ function doFoo() {
 	}
 }
 
+class ContainerClass {
+	public FinalClass $finalClass;
+	public FinalClass $nonFinalClass;
+
+	public Foo $foo;
+
+	public User $user;
+
+	/** @var array<User> */
+	public array $arrayOfUsers;
+}
+
+function dooNestedUnset(ContainerClass $containerClass) {
+	unset($containerClass->finalClass->publicFinalProperty);
+	unset($containerClass->finalClass->publicProperty);
+	unset($containerClass->finalClass);
+
+	unset($containerClass->nonFinalClass->publicFinalProperty);
+	unset($containerClass->nonFinalClass->publicProperty);
+	unset($containerClass->nonFinalClass);
+
+	unset($containerClass->foo->iii);
+	unset($containerClass->foo);
+
+	unset($containerClass->user->name);
+	unset($containerClass->user->fullName);
+	unset($containerClass->user);
+
+	unset($containerClass->arrayOfUsers[0]->name);
+	unset($containerClass->arrayOfUsers[0]->name);
+	unset($containerClass->arrayOfUsers['hans']->fullName);
+	unset($containerClass->arrayOfUsers['hans']->fullName);
+	unset($containerClass->arrayOfUsers);
+}
+
 class Bug12695
 {
 	/** @var int[] */