MethodReflection - fix isInternal vs. isBuiltin

ondrejmirtes · ondrejmirtes · commit 3024c02e844d · 2025-04-19T13:38:12.000+02:00
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -119,6 +119,11 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return $this->throwType;
diff --git a/src/Reflection/Dummy/ChangedTypeMethodReflection.php b/src/Reflection/Dummy/ChangedTypeMethodReflection.php
@@ -110,6 +110,16 @@ public function isInternal(): TrinaryLogic
 		return $this->reflection->isInternal();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		$builtin = $this->reflection->isBuiltin();
+		if (is_bool($builtin)) {
+			return TrinaryLogic::createFromBoolean($builtin);
+		}
+
+		return $builtin;
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return $this->reflection->getThrowType();
diff --git a/src/Reflection/Dummy/DummyConstructorReflection.php b/src/Reflection/Dummy/DummyConstructorReflection.php
@@ -97,6 +97,11 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createMaybe();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return null;
diff --git a/src/Reflection/Dummy/DummyMethodReflection.php b/src/Reflection/Dummy/DummyMethodReflection.php
@@ -94,6 +94,11 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createMaybe();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createMaybe();
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return null;
diff --git a/src/Reflection/ExtendedMethodReflection.php b/src/Reflection/ExtendedMethodReflection.php
@@ -49,6 +49,8 @@ public function isFinalByKeyword(): TrinaryLogic;
 
 	public function isAbstract(): TrinaryLogic|bool;
 
+	public function isBuiltin(): TrinaryLogic|bool;
+
 	/**
 	 * This indicates whether the method has phpstan-pure
 	 * or phpstan-impure annotation above it.
diff --git a/src/Reflection/Native/NativeMethodReflection.php b/src/Reflection/Native/NativeMethodReflection.php
@@ -140,6 +140,11 @@ public function isDeprecated(): TrinaryLogic
 	}
 
 	public function isInternal(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
+	public function isBuiltin(): TrinaryLogic
 	{
 		return TrinaryLogic::createFromBoolean($this->reflection->isInternal());
 	}
diff --git a/src/Reflection/Php/ClosureCallMethodReflection.php b/src/Reflection/Php/ClosureCallMethodReflection.php
@@ -142,6 +142,16 @@ public function isInternal(): TrinaryLogic
 		return $this->nativeMethodReflection->isInternal();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		$builtin = $this->nativeMethodReflection->isBuiltin();
+		if (is_bool($builtin)) {
+			return TrinaryLogic::createFromBoolean($builtin);
+		}
+
+		return $builtin;
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return $this->nativeMethodReflection->getThrowType();
diff --git a/src/Reflection/Php/EnumCasesMethodReflection.php b/src/Reflection/Php/EnumCasesMethodReflection.php
@@ -111,6 +111,11 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createYes();
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return null;
diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -379,7 +379,12 @@ public function isDeprecated(): TrinaryLogic
 
 	public function isInternal(): TrinaryLogic
 	{
-		return TrinaryLogic::createFromBoolean($this->isInternal || $this->reflection->isInternal());
+		return TrinaryLogic::createFromBoolean($this->isInternal);
+	}
+
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createFromBoolean($this->reflection->isInternal());
 	}
 
 	public function isFinal(): TrinaryLogic
diff --git a/src/Reflection/ResolvedMethodReflection.php b/src/Reflection/ResolvedMethodReflection.php
@@ -150,6 +150,16 @@ public function isInternal(): TrinaryLogic
 		return $this->reflection->isInternal();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		$builtin = $this->reflection->isBuiltin();
+		if (is_bool($builtin)) {
+			return TrinaryLogic::createFromBoolean($builtin);
+		}
+
+		return $builtin;
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return $this->reflection->getThrowType();
diff --git a/src/Reflection/Type/IntersectionTypeMethodReflection.php b/src/Reflection/Type/IntersectionTypeMethodReflection.php
@@ -152,6 +152,11 @@ public function isInternal(): TrinaryLogic
 		return TrinaryLogic::lazyMaxMin($this->methods, static fn (MethodReflection $method): TrinaryLogic => $method->isInternal());
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::lazyMaxMin($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => is_bool($method->isBuiltin()) ? TrinaryLogic::createFromBoolean($method->isBuiltin()) : $method->isBuiltin());
+	}
+
 	public function getThrowType(): ?Type
 	{
 		$types = [];
diff --git a/src/Reflection/Type/UnionTypeMethodReflection.php b/src/Reflection/Type/UnionTypeMethodReflection.php
@@ -132,7 +132,12 @@ public function isFinalByKeyword(): TrinaryLogic
 
 	public function isInternal(): TrinaryLogic
 	{
-		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (MethodReflection $method): TrinaryLogic => $method->isInternal());
+		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->isInternal());
+	}
+
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => is_bool($method->isBuiltin()) ? TrinaryLogic::createFromBoolean($method->isBuiltin()) : $method->isBuiltin());
 	}
 
 	public function getThrowType(): ?Type
diff --git a/src/Reflection/WrappedExtendedMethodReflection.php b/src/Reflection/WrappedExtendedMethodReflection.php
@@ -123,6 +123,11 @@ public function isInternal(): TrinaryLogic
 		return $this->method->isInternal();
 	}
 
+	public function isBuiltin(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 	public function getThrowType(): ?Type
 	{
 		return $this->method->getThrowType();
diff --git a/src/Rules/Methods/OverridingMethodRule.php b/src/Rules/Methods/OverridingMethodRule.php
@@ -214,10 +214,15 @@ public function processNode(Node $node, Scope $scope): array
 		$prototypeReturnType = $prototypeVariant->getNativeReturnType();
 		$reportReturnType = true;
 		if ($this->phpVersion->hasTentativeReturnTypes()) {
-			$reportReturnType = !$realPrototype instanceof MethodPrototypeReflection || $realPrototype->getTentativeReturnType() === null || $prototype->isInternal()->no();
+			$reportReturnType = !$realPrototype instanceof MethodPrototypeReflection
+				|| $realPrototype->getTentativeReturnType() === null
+				|| (is_bool($prototype->isBuiltin()) ? !$prototype->isBuiltin() : $prototype->isBuiltin()->no());
 		} else {
 			if ($realPrototype instanceof MethodPrototypeReflection && $realPrototype->isInternal()) {
-				if ($prototype->isInternal()->yes() && $prototypeDeclaringClass->getName() !== $realPrototype->getDeclaringClass()->getName()) {
+				if (
+					(is_bool($prototype->isBuiltin()) ? $prototype->isBuiltin() : $prototype->isBuiltin()->yes())
+					&& $prototypeDeclaringClass->getName() !== $realPrototype->getDeclaringClass()->getName()
+				) {
 					$realPrototypeVariant = $realPrototype->getVariants()[0];
 					if (
 						$prototypeReturnType instanceof MixedType
@@ -228,7 +233,10 @@ public function processNode(Node $node, Scope $scope): array
 					}
 				}
 
-				if ($reportReturnType && $prototype->isInternal()->yes()) {
+				if (
+					$reportReturnType
+					&& (is_bool($prototype->isBuiltin()) ? $prototype->isBuiltin() : $prototype->isBuiltin()->yes())
+				) {
 					$reportReturnType = !$this->hasReturnTypeWillChangeAttribute($node->getOriginalNode());
 				}
 			}
diff --git a/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php b/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php
@@ -28,6 +28,7 @@
 use function get_defined_functions;
 use function getenv;
 use function implode;
+use function is_bool;
 use function mkdir;
 use function sort;
 use function strpos;
@@ -349,6 +350,14 @@ private static function generateFunctionMethodBaseDescription($reflection): stri
 			$result .= 'Is internal: ' . $reflection->isInternal()->describe() . "\n";
 		}
 
+		if (is_bool($reflection->isBuiltin()) && $reflection->isBuiltin()) {
+			$result .= 'Is built-in' . "\n";
+		}
+
+		if (!is_bool($reflection->isBuiltin()) && !$reflection->isBuiltin()->no()) {
+			$result .= 'Is built-in: ' . $reflection->isBuiltin()->describe() . "\n";
+		}
+
 		if (! $reflection->returnsByReference()->no()) {
 			$result .= 'Returns by reference: ' . $reflection->returnsByReference()->describe() . "\n";
 		}

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,11 @@ public function isInternal(): TrinaryLogic`
`119`	`119`	`return TrinaryLogic::createNo();`
`120`	`120`	`}`
`121`	`121`
	`122`	`+ public function isBuiltin(): TrinaryLogic`
	`123`	`+ {`
	`124`	`+ return TrinaryLogic::createNo();`
	`125`	`+ }`
	`126`	`+`
`122`	`127`	`public function getThrowType(): ?Type`
`123`	`128`	`{`
`124`	`129`	`return $this->throwType;`
Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,11 @@ public function isInternal(): TrinaryLogic`
`97`	`97`	`return TrinaryLogic::createMaybe();`
`98`	`98`	`}`
`99`	`99`
	`100`	`+ public function isBuiltin(): TrinaryLogic`
	`101`	`+ {`
	`102`	`+ return TrinaryLogic::createMaybe();`
	`103`	`+ }`
	`104`	`+`
`100`	`105`	`public function getThrowType(): ?Type`
`101`	`106`	`{`
`102`	`107`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,11 @@ public function isInternal(): TrinaryLogic`
`94`	`94`	`return TrinaryLogic::createMaybe();`
`95`	`95`	`}`
`96`	`96`
	`97`	`+ public function isBuiltin(): TrinaryLogic`
	`98`	`+ {`
	`99`	`+ return TrinaryLogic::createMaybe();`
	`100`	`+ }`
	`101`	`+`
`97`	`102`	`public function getThrowType(): ?Type`
`98`	`103`	`{`
`99`	`104`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -140,6 +140,11 @@ public function isDeprecated(): TrinaryLogic`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`public function isInternal(): TrinaryLogic`
	`143`	`+ {`
	`144`	`+ return TrinaryLogic::createNo();`
	`145`	`+ }`
	`146`	`+`
	`147`	`+ public function isBuiltin(): TrinaryLogic`
`143`	`148`	`{`
`144`	`149`	`return TrinaryLogic::createFromBoolean($this->reflection->isInternal());`
`145`	`150`	`}`
Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,11 @@ public function isInternal(): TrinaryLogic`
`111`	`111`	`return TrinaryLogic::createNo();`
`112`	`112`	`}`
`113`	`113`
	`114`	`+ public function isBuiltin(): TrinaryLogic`
	`115`	`+ {`
	`116`	`+ return TrinaryLogic::createYes();`
	`117`	`+ }`
	`118`	`+`
`114`	`119`	`public function getThrowType(): ?Type`
`115`	`120`	`{`
`116`	`121`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,12 @@ public function isDeprecated(): TrinaryLogic`
`379`	`379`
`380`	`380`	`public function isInternal(): TrinaryLogic`
`381`	`381`	`{`
`382`		`- return TrinaryLogic::createFromBoolean($this->isInternal \|\| $this->reflection->isInternal());`
	`382`	`+ return TrinaryLogic::createFromBoolean($this->isInternal);`
	`383`	`+ }`
	`384`	`+`
	`385`	`+ public function isBuiltin(): TrinaryLogic`
	`386`	`+ {`
	`387`	`+ return TrinaryLogic::createFromBoolean($this->reflection->isInternal());`
`383`	`388`	`}`
`384`	`389`
`385`	`390`	`public function isFinal(): TrinaryLogic`