Avoid error with constant name $

Author: VincentLanglet

phpstan-baseline.neon

@@ -236,7 +236,7 @@ parameters:
 
 		-
 			message: "#^Dead catch \\- PHPStan\\\\BetterReflection\\\\Identifier\\\\Exception\\\\InvalidIdentifierName is never thrown in the try block\\.$#"
-			count: 3
+			count: 4
 			path: src/Reflection/BetterReflection/BetterReflectionProvider.php
 
 		-

src/Reflection/BetterReflection/BetterReflectionProvider.php

@@ -434,6 +434,8 @@ public function resolveConstantName(Node\Name $nameNode, ?NamespaceAnswerer $nam
 				return true;
 			} catch (IdentifierNotFound) {
 				// pass
+			} catch (InvalidIdentifierName) {
+				// pass
 			} catch (UnableToCompileNode) {
 				// pass
 			}

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -1506,6 +1506,12 @@ public function testBug12979(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug12095(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-12095.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]

tests/PHPStan/Analyser/data/bug-12095.php

@@ -0,0 +1,15 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12095;
+
+class HelloWorld
+{
+	public const XXX = '$';
+
+	public function sayHello(): void
+	{
+		if(defined(self::XXX)) {
+			die(0);
+		}
+	}
+}