Skip to content

Commit 0d92315

Browse files
staabmondrejmirtes
authored andcommitted
Implement BinaryPowHandler
1 parent 9eb4e6d commit 0d92315

File tree

3 files changed

+73
-0
lines changed

3 files changed

+73
-0
lines changed
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
<?php declare(strict_types = 1);
2+
3+
namespace PHPStan\Analyser\Generator\ExprHandler;
4+
5+
use Generator;
6+
use PhpParser\Node\Expr;
7+
use PhpParser\Node\Stmt;
8+
use PHPStan\Analyser\ExpressionContext;
9+
use PHPStan\Analyser\Generator\ExprAnalysisRequest;
10+
use PHPStan\Analyser\Generator\ExprAnalysisResult;
11+
use PHPStan\Analyser\Generator\ExprHandler;
12+
use PHPStan\Analyser\Generator\GeneratorScope;
13+
use PHPStan\Analyser\SpecifiedTypes;
14+
use PHPStan\DependencyInjection\AutowiredService;
15+
use PHPStan\Reflection\InitializerExprTypeResolver;
16+
use function array_merge;
17+
18+
/**
19+
* @implements ExprHandler<Expr\BinaryOp\Pow>
20+
*/
21+
#[AutowiredService]
22+
final class BinaryPowHandler implements ExprHandler
23+
{
24+
25+
public function __construct(private InitializerExprTypeResolver $initializerExprTypeResolver)
26+
{
27+
}
28+
29+
public function supports(Expr $expr): bool
30+
{
31+
return $expr instanceof Expr\BinaryOp\Pow;
32+
}
33+
34+
public function analyseExpr(Stmt $stmt, Expr $expr, GeneratorScope $scope, ExpressionContext $context, ?callable $alternativeNodeCallback): Generator
35+
{
36+
$leftResult = yield new ExprAnalysisRequest($stmt, $expr->left, $scope, $context, $alternativeNodeCallback);
37+
$rightResult = yield new ExprAnalysisRequest($stmt, $expr->right, $leftResult->scope, $context, $alternativeNodeCallback);
38+
39+
return new ExprAnalysisResult(
40+
$this->initializerExprTypeResolver->getPowTypeFromTypes($expr->left, $expr->right, $leftResult->type, $rightResult->type),
41+
$this->initializerExprTypeResolver->getPowTypeFromTypes($expr->left, $expr->right, $leftResult->nativeType, $rightResult->nativeType),
42+
$rightResult->scope,
43+
hasYield: $leftResult->hasYield || $rightResult->hasYield,
44+
isAlwaysTerminating: $leftResult->isAlwaysTerminating || $rightResult->isAlwaysTerminating,
45+
throwPoints: array_merge($leftResult->throwPoints, $rightResult->throwPoints),
46+
impurePoints: array_merge($leftResult->impurePoints, $rightResult->impurePoints),
47+
specifiedTruthyTypes: new SpecifiedTypes(),
48+
specifiedFalseyTypes: new SpecifiedTypes(),
49+
specifiedNullTypes: new SpecifiedTypes(),
50+
);
51+
}
52+
53+
}

src/Reflection/InitializerExprTypeResolver.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,6 +1653,11 @@ public function getPowType(Expr $left, Expr $right, callable $getTypeCallback):
16531653
$leftType = $getTypeCallback($left);
16541654
$rightType = $getTypeCallback($right);
16551655

1656+
return $this->getPowTypeFromTypes($left, $right, $leftType, $rightType);
1657+
}
1658+
1659+
public function getPowTypeFromTypes(Expr $left, Expr $right, Type $leftType, Type $rightType): Type
1660+
{
16561661
$extensionSpecified = $this->operatorTypeSpecifyingExtensionRegistryProvider->getRegistry()
16571662
->callOperatorTypeSpecifyingExtensions(new BinaryOp\Pow($left, $right), $leftType, $rightType);
16581663
if ($extensionSpecified !== null) {

tests/PHPStan/Analyser/Generator/data/gnsr.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,21 @@ public function doMul($a, $b, int $c, int $d): void
117117
assertNativeType('int', $c * $d);
118118
}
119119

120+
/**
121+
* @param int $a
122+
* @param int $b
123+
* @return void
124+
*/
125+
public function doPow($a, $b, int $c, int $d): void
126+
{
127+
assertType('(float|int)', $a ** $b);
128+
assertNativeType('(float|int)', $a ** $b);
129+
assertType('1', 1 ** 1);
130+
assertNativeType('1', 1 ** 1);
131+
assertType('(float|int)', $c ** $d);
132+
assertNativeType('(float|int)', $c ** $d);
133+
}
134+
120135
/**
121136
* @param string $a
122137
* @param string $b

0 commit comments

Comments
 (0)