Improve

Author: VincentLanglet

src/Type/ObjectType.php

@@ -1582,17 +1582,20 @@ private function getInterfaces(): array
 
 	public function tryRemove(Type $typeToRemove): ?Type
 	{
-		foreach (UnionType::EQUAL_UNION_CLASSES as $baseClass => $classes) {
-			if ($this->getClassName() !== $baseClass || !($typeToRemove instanceof ObjectType)) {
-				continue;
-			}
+		if ($typeToRemove instanceof ObjectType) {
+			foreach (UnionType::EQUAL_UNION_CLASSES as $baseClass => $classes) {
+				if ($this->getClassName() !== $baseClass) {
+					continue;
+				}
 
-			foreach ($classes as $index => $class) {
-				if ($typeToRemove->getClassName() === $class) {
-					unset($classes[$index]);
-					return TypeCombinator::union(
-						...array_map(static fn (string $objectClass): Type => new ObjectType($objectClass), $classes),
-					);
+				foreach ($classes as $index => $class) {
+					if ($typeToRemove->getClassName() === $class) {
+						unset($classes[$index]);
+
+						return TypeCombinator::union(
+							...array_map(static fn(string $objectClass): Type => new ObjectType($objectClass), $classes),
+						);
+					}
 				}
 			}
 		}

src/Type/UnionType.php

@@ -213,6 +213,7 @@ public function acceptsWithReason(Type $type, bool $strictTypes): AcceptsResult
 			if ($this->accepts($union, $strictTypes)->yes()) {
 				return AcceptsResult::createYes();
 			}
+			break;
 		}
 
 		$result = AcceptsResult::createNo();