Optimize twig function usages

Author: iMattPro

skeleton/notification/type/sample.php.twig

@@ -1,3 +1,4 @@
+{% set is_phpbb_pre_32 = skeleton_version_compare(REQUIREMENTS.phpbb_version_max, "3.2", "<") %}
 <?php
 /**
  *
@@ -157,7 +158,7 @@ class sample extends \phpbb\notification\type\base
 	 *
 	 * @param array $data The type specific data
 	 * @param array $pre_create_data Data from pre_create_insert_array()
-{% if skeleton_version_compare(REQUIREMENTS.phpbb_version_max, "3.2", "<") %}{# for phpBB 3.1.x only #}
+{% if is_phpbb_pre_32 %}{# for phpBB 3.1.x only #}
 	 *
 	 * @return array Array of data ready to be inserted into the database
 {% endif %}{# for phpBB >= 3.2.x #}
@@ -166,7 +167,7 @@ class sample extends \phpbb\notification\type\base
 	{
 		$this->set_data('{{ EXTENSION.extension_name|lower }}_sample_name', $data['{{ EXTENSION.extension_name|lower }}_sample_name']);
 
-{% if skeleton_version_compare(REQUIREMENTS.phpbb_version_max, "3.2", "<") %}{# for phpBB 3.1.x only #}
+{% if is_phpbb_pre_32 %}{# for phpBB 3.1.x only #}
 		return parent::create_insert_array($data, $pre_create_data);
 {% else %}{# for phpBB >= 3.2.x #}
 		parent::create_insert_array($data, $pre_create_data);

skeleton/phpunit.xml.dist.twig

@@ -1,3 +1,4 @@
+{% set is_phpbb_pre_33 = skeleton_version_compare(REQUIREMENTS.phpbb_version_max, "3.3", "<") %}
 <?xml version="1.0" encoding="UTF-8"?>
 
 <phpunit backupGlobals="true"
@@ -8,7 +9,7 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-{% if skeleton_version_compare(REQUIREMENTS.phpbb_version_max, "3.3", "<") %}
+{% if is_phpbb_pre_33 %}
          syntaxCheck="false"
 {% endif %}
          verbose="true"
@@ -20,12 +21,12 @@
 			<exclude>./tests/functional</exclude>
 		</testsuite>
 		<testsuite name="Extension Functional Tests">
-			<directory suffix="_test.php"{% if skeleton_version_compare(REQUIREMENTS.phpbb_version_max, "3.3", "<") %} phpVersion="5.3.19" phpVersionOperator=">="{% endif %}>./tests/functional/</directory>
+			<directory suffix="_test.php"{% if is_phpbb_pre_33 %} phpVersion="5.3.19" phpVersionOperator=">="{% endif %}>./tests/functional/</directory>
 		</testsuite>
 	</testsuites>
 
 	<filter>
-{% if skeleton_version_compare(REQUIREMENTS.phpbb_version_max, "3.3", "<") %}
+{% if is_phpbb_pre_33 %}
 		<blacklist>
 			<directory>./tests/</directory>
 		</blacklist>