Validate language before setting it

Author: iMattPro

entity/rule.php

@@ -535,11 +535,28 @@ public function get_language()
 	 * @param string $language language iso
 	 * @return rule_interface $this object for chaining calls; load()->set()->save()
 	 * @access public
+	 * @throws \phpbb\boardrules\exception\unexpected_value
 	 */
 	public function set_language($language)
 	{
 		if (!isset($this->data['rule_language']))
 		{
+			// Validate the requested language ISO is installed
+			if ($language !== '')
+			{
+				$sql = 'SELECT lang_id
+					FROM ' . LANG_TABLE . "
+					WHERE lang_iso = '" . $this->db->sql_escape($language) . "'";
+				$result = $this->db->sql_query($sql);
+				$lang_id = $this->db->sql_fetchfield('lang_id');
+				$this->db->sql_freeresult($result);
+
+				if (!$lang_id)
+				{
+					throw new \phpbb\boardrules\exception\unexpected_value(array('rule_language', 'WRONG_DATA_LANG', 'UNEXPECTED_VALUE'));
+				}
+			}
+
 			$this->data['rule_language'] = $language;
 		}
 

tests/entity/fixtures/rule.xml

@@ -70,4 +70,16 @@
 			<value>7</value>
 		</row>
 	</table>
+	<table name="phpbb_lang">
+		<column>lang_id</column>
+		<column>lang_iso</column>
+		<row>
+			<value>1</value>
+			<value>en</value>
+		</row>
+		<row>
+			<value>2</value>
+			<value>en-us</value>
+		</row>
+	</table>
 </dataset>

tests/entity/rule_entity_language_test.php

@@ -75,6 +75,12 @@ public function test_set_language($data, $language)
 		// Setup the entity class
 		$entity = $this->get_rule_entity();
 
+		// Assert that the anchor matches what's expected
+		if ($language !== 'en')
+		{
+			$this->setExpectedException('\phpbb\boardrules\exception\unexpected_value');
+		}
+
 		// Set the anchor
 		$entity->set_language($language);