ISSUE-337: fix phpstan

Author: tatevikg1

src/Controller/SubscriberController.php

@@ -27,29 +27,25 @@ class SubscriberController extends AbstractController
     use AuthenticationTrait;
 
     private SubscriberRepository $subscriberRepository;
-    private SerializerInterface $serializer;
 
     /**
      * @param Authentication $authentication
      * @param SubscriberRepository $repository
-     * @param SerializerInterface $serializer
      */
     public function __construct(
         Authentication $authentication,
-        SubscriberRepository $repository,
-        SerializerInterface $serializer
+        SubscriberRepository $repository
     ) {
         $this->authentication = $authentication;
         $this->subscriberRepository = $repository;
-        $this->serializer = $serializer;
     }
 
     /**
      * Creates a new subscriber (if the provided data is valid and there is no subscriber with the given email
      * address yet).
      */
     #[Route('/subscribers', name: 'create_subscriber', methods: ['POST'])]
-    public function postAction(Request $request): JsonResponse
+    public function postAction(Request $request, SerializerInterface $serializer): JsonResponse
     {
         $this->requireAuthentication($request);
         $data = $request->getPayload();
@@ -59,18 +55,20 @@ public function postAction(Request $request): JsonResponse
         if ($this->subscriberRepository->findOneByEmail($email) !== null) {
             throw new ConflictHttpException('This resource already exists.', null, 1513439108);
         }
-
+        // @phpstan-ignore-next-line
         $subscriber = new Subscriber();
         $subscriber->setEmail($email);
-        $subscriber->setConfirmed((bool)$data->get('confirmed'));
-        $subscriber->setBlacklisted((bool)$data->get('blacklisted'));
-        $subscriber->setHtmlEmail((bool)$data->get('html_email'));
-        $subscriber->setDisabled((bool)$data->get('disabled'));
+        $subscriber->setConfirmed((bool)$data->get('confirmed', false));
+        $subscriber->setBlacklisted((bool)$data->get('blacklisted', false));
+        $subscriber->setHtmlEmail((bool)$data->get('html_email', true));
+        $subscriber->setDisabled((bool)$data->get('disabled', false));
+
         $this->subscriberRepository->save($subscriber);
 
         return new JsonResponse(
-            $this->serializer->serialize($subscriber, 'json'),
-            Response::HTTP_CREATED, [],
+            $serializer->serialize($subscriber, 'json'),
+            Response::HTTP_CREATED,
+            [],
             true
         );
     }

tests/Integration/Controller/ListControllerTest.php

@@ -22,7 +22,7 @@ class ListControllerTest extends AbstractTestController
 {
     public function testControllerIsAvailableViaContainer()
     {
-        self::assertInstanceOf(ListController::class, self::getClient()->getContainer()->get(ListController::class));
+        self::assertInstanceOf(ListController::class, self::getContainer()->get(ListController::class));
     }
 
     public function testGetListsWithoutSessionKeyReturnsForbiddenStatus()

tests/Integration/Controller/SessionControllerTest.php

@@ -30,7 +30,7 @@ public function testControllerIsAvailableViaContainer()
     {
         self::assertInstanceOf(
             SessionController::class,
-            self::getClient()->getContainer()->get(SessionController::class)
+            self:: getContainer()->get(SessionController::class)
         );
     }
 

tests/Integration/Controller/SubscriberControllerTest.php

@@ -29,7 +29,7 @@ public function testControllerIsAvailableViaContainer()
     {
         self::assertInstanceOf(
             SubscriberController::class,
-            self::getClient()->getContainer()->get(SubscriberController::class)
+            self::getContainer()->get(SubscriberController::class)
         );
     }