switch to Mockery;

Author: ashnazg

composer.json

@@ -12,6 +12,7 @@
         "psr-0": {"phpDocumentor": ["src/", "tests/unit"]}
     },
     "require-dev": {
-        "phpunit/phpunit": "^6.5"
+        "phpunit/phpunit": "^6.5",
+        "mockery/mockery": "^1.0"
     }
 }

composer.lock

@@ -24,7 +24,7 @@
  */
 class AttributeTest extends TestCase
 {
-    /** @var \phpDocumentor\GraphViz\Attribute */
+    /** @var Attribute */
     protected $fixture = null;
 
     /**
@@ -46,7 +46,7 @@ public function testConstruct()
     {
         $fixture = new Attribute('MyKey', 'MyValue');
         $this->assertInstanceOf(
-            'phpDocumentor\GraphViz\Attribute',
+            Attribute::class,
             $fixture
         );
         $this->assertSame('MyKey', $fixture->getKey());
@@ -56,8 +56,8 @@ public function testConstruct()
     /**
      * Tests the getting and setting of the key.
      *
-     * @covers \phpDocumentor\GraphViz\Attribute::getKey
-     * @covers \phpDocumentor\GraphViz\Attribute::setKey
+     * @covers phpDocumentor\GraphViz\Attribute::getKey
+     * @covers phpDocumentor\GraphViz\Attribute::setKey
      */
     public function testKey()
     {
@@ -81,8 +81,8 @@ public function testKey()
     /**
      * Tests the getting and setting of the value.
      *
-     * @covers \phpDocumentor\GraphViz\Attribute::getValue
-     * @covers \phpDocumentor\GraphViz\Attribute::setValue
+     * @covers phpDocumentor\GraphViz\Attribute::getValue
+     * @covers phpDocumentor\GraphViz\Attribute::setValue
      */
     public function testValue()
     {
@@ -106,7 +106,7 @@ public function testValue()
     /**
      * Tests whether a string starting with a < is recognized as HTML.
      *
-     * @covers \phpDocumentor\GraphViz\Attribute::isValueInHtml
+     * @covers phpDocumentor\GraphViz\Attribute::isValueInHtml
      */
     public function testIsValueInHtml()
     {
@@ -126,7 +126,7 @@ public function testIsValueInHtml()
     /**
      * Tests whether the toString provides a valid GraphViz attribute string.
      *
-     * @covers \phpDocumentor\GraphViz\Attribute::__toString
+     * @covers phpDocumentor\GraphViz\Attribute::__toString
      */
     public function testToString()
     {
@@ -162,8 +162,8 @@ public function testToString()
     /**
      * Tests whether the toString provides a valid GraphViz attribute string.
      *
-     * @covers \phpDocumentor\GraphViz\Attribute::__toString
-     * @covers \phpDocumentor\GraphViz\Attribute::encodeSpecials
+     * @covers phpDocumentor\GraphViz\Attribute::__toString
+     * @covers phpDocumentor\GraphViz\Attribute::encodeSpecials
      */
     public function testToStringWithSpecials()
     {
@@ -192,7 +192,7 @@ public function testToStringWithSpecials()
     /**
      * Tests whether the isValueContainingSpecials function
      *
-     * @covers \phpDocumentor\GraphViz\Attribute::isValueContainingSpecials
+     * @covers phpDocumentor\GraphViz\Attribute::isValueContainingSpecials
      */
     public function testIsValueContainingSpecials()
     {

tests/phpDocumentor/GraphViz/Test/AttributeTest.php

@@ -13,6 +13,7 @@
 
 namespace phpDocumentor\GraphViz\Test;
 
+use Mockery as m;
 use phpDocumentor\GraphViz\Edge;
 use phpDocumentor\GraphViz\Node;
 use PHPUnit\Framework\TestCase;
@@ -27,26 +28,13 @@
  */
 class EdgeTest extends TestCase
 {
-    /**
-     * @var phpDocumentor\GraphViz\Edge
-     */
-    protected $fixture;
-
-    /**
-     * Sets up the fixture, for example, opens a network connection.
-     * This method is called before a test is executed.
-     */
-    protected function setUp()
-    {
-        $this->fixture = new Edge(new Node('from'), new Node('to'));
-    }
-
     /**
      * Tears down the fixture, for example, closes a network connection.
      * This method is called after a test is executed.
      */
     protected function tearDown()
     {
+        m::close();
     }
 
     /**
@@ -56,14 +44,12 @@ protected function tearDown()
      */
     public function testConstruct()
     {
-        $this->markTestIncomplete('Need to redo mock technique.');
-
-        $fromNode = $this->getMock('phpDocumentor\GraphViz\Node', [], [], '', false);
-        $toNode = $this->getMock('phpDocumentor\GraphViz\Node', [], [], '', false);
+        $fromNode = m::mock(Node::class);
+        $toNode = m::mock(Node::class);
         $fixture = new Edge($fromNode, $toNode);
 
         $this->assertInstanceOf(
-            'phpDocumentor\GraphViz\Edge',
+            Edge::class,
             $fixture
         );
         $this->assertSame(
@@ -84,7 +70,7 @@ public function testConstruct()
     public function testCreate()
     {
         $this->assertInstanceOf(
-            'phpDocumentor\GraphViz\Edge',
+            Edge::class,
             Edge::create(new Node('from'), new Node('to'))
         );
     }
@@ -125,9 +111,10 @@ public function testGetTo()
     public function testCall()
     {
         $label = 'my label';
-        $this->assertInstanceOf('phpDocumentor\GraphViz\Edge', $this->fixture->setLabel($label));
-        $this->assertSame($label, $this->fixture->getLabel()->getValue());
-        $this->assertNull($this->fixture->someNonExcistingMethod());
+        $fixture = new Edge(new Node('from'), new Node('to'));
+        $this->assertInstanceOf(Edge::class, $fixture->setLabel($label));
+        $this->assertSame($label, $fixture->getLabel()->getValue());
+        $this->assertNull($fixture->someNonExcistingMethod());
     }
 
     /**
@@ -138,8 +125,9 @@ public function testCall()
      */
     public function testToString()
     {
-        $this->fixture->setLabel('MyLabel');
-        $this->fixture->setWeight(45);
+        $fixture = new Edge(new Node('from'), new Node('to'));
+        $fixture->setLabel('MyLabel');
+        $fixture->setWeight(45);
 
         $dot = <<<DOT
 "from" -> "to" [
@@ -148,6 +136,6 @@ public function testToString()
 ]
 DOT;
 
-        $this->assertSame($dot, (string) $this->fixture);
+        $this->assertSame($dot, (string) $fixture);
     }
 }