add initial data filtering support to python sdk #101
+234
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omer9564
approved these changes
Aug 15, 2024
Contributor
omer9564
left a comment
omer9564
left a comment
There was a problem hiding this comment.
Few comments that require fixing
| Read more about setting up the PDP at https://docs.permit.io/sdk/python/quickstart-python/#2-setup-your-pdp-policy-decision-point-container" | ||
| ) | ||
|
|
||
| async def filter_resources( |
Contributor
There was a problem hiding this comment.
This should be in a separate file and should only be imported if the relevant optional dependency was chosen, otherwise you will force installing irrelevant packages
| """ | ||
| return await self._enforcer.check(user, action, resource, context) | ||
|
|
||
| async def filter_resources( |
| loguru>=0.7.0,<1 | ||
| pydantic[email]>=1.10.7 | ||
| typing-extensions>=4.5.0,<5 | ||
| permit-datafilter>=0.0.3,<1 |
Contributor
There was a problem hiding this comment.
This should be optional dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.