Skip to content

Commit e48477a

Browse files
committed
fix: expand site and topic clickable area
1 parent 152e754 commit e48477a

File tree

2 files changed

+36
-24
lines changed

2 files changed

+36
-24
lines changed

app/src/main/java/com/paulcoding/hviewer/ui/page/sites/SitesPage.kt

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import androidx.compose.foundation.layout.Column
77
import androidx.compose.foundation.layout.Row
88
import androidx.compose.foundation.layout.Spacer
99
import androidx.compose.foundation.layout.fillMaxSize
10+
import androidx.compose.foundation.layout.fillMaxWidth
1011
import androidx.compose.foundation.layout.height
1112
import androidx.compose.foundation.layout.padding
1213
import androidx.compose.foundation.rememberScrollState
@@ -95,14 +96,12 @@ fun SitesPage(
9596
Empty(navToSettings)
9697
} else
9798
siteConfigs.sites.keys.map { site ->
98-
Box(modifier = Modifier.clickable {
99-
navToTopics(site)
100-
}) {
101-
siteConfigs.sites[site]?.let { siteConfig ->
102-
Site(
103-
key = site,
104-
site = siteConfig
105-
)
99+
siteConfigs.sites[site]?.let { siteConfig ->
100+
Site(
101+
key = site,
102+
site = siteConfig
103+
) {
104+
navToTopics(site)
106105
}
107106
}
108107
}
@@ -112,14 +111,20 @@ fun SitesPage(
112111
}
113112

114113
@Composable
115-
fun Site(site: SiteConfig, key: String) {
116-
Row(
117-
modifier = Modifier.padding(horizontal = 16.dp, vertical = 12.dp),
118-
verticalAlignment = Alignment.CenterVertically,
119-
horizontalArrangement = Arrangement.spacedBy(8.dp)
120-
) {
121-
site.SiteIcon()
122-
Text(key)
114+
fun Site(site: SiteConfig, key: String, onClick: () -> Unit) {
115+
Box(modifier = Modifier.clickable {
116+
onClick()
117+
}) {
118+
Row(
119+
modifier = Modifier
120+
.padding(horizontal = 16.dp, vertical = 12.dp)
121+
.fillMaxWidth(),
122+
verticalAlignment = Alignment.CenterVertically,
123+
horizontalArrangement = Arrangement.spacedBy(8.dp)
124+
) {
125+
site.SiteIcon()
126+
Text(key)
127+
}
123128
}
124129
}
125130

app/src/main/java/com/paulcoding/hviewer/ui/page/topics/TopicsPage.kt

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,24 @@ fun TopicsPage(
4343
) {
4444
LazyVerticalStaggeredGrid(
4545
columns = StaggeredGridCells.Fixed(2),
46-
horizontalArrangement = Arrangement.spacedBy(16.dp), verticalItemSpacing = 16.dp
46+
horizontalArrangement = Arrangement.spacedBy(16.dp)
4747
) {
4848
items(tags) { tag ->
49-
Box(modifier = Modifier
50-
.align(Alignment.Center)
51-
.clickable {
52-
navToTopic(tag)
53-
})
54-
Text(tag)
49+
Topic(tag) {
50+
navToTopic(tag)
51+
}
5552
}
5653
}
5754
}
5855
}
59-
}
56+
}
57+
58+
@Composable
59+
fun Topic(tag: String, onClick: () -> Unit) {
60+
Box(modifier = Modifier
61+
.clickable { onClick() }
62+
.padding(horizontal = 16.dp, vertical = 12.dp)
63+
) {
64+
Text(tag)
65+
}
66+
}

0 commit comments

Comments
 (0)