Skip to content

Fix backwards-in-time solve for AbstractSRKs #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix backwards-in-time solve for AbstractSRKs #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions diffrax/_solver/srk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,7 @@ def step(
else:
ignore_stage_g = jnp.array(self.tableau.ignore_stage_g)

# time increment
h = t1 - t0

# First the drift related stuff
# # First the drift related stuff
a = self._embed_a_lower(self.tableau.a, dtype)
c = jnp.asarray(
np.insert(self.tableau.c, 0, 0.0), dtype=complex_to_real_dtype(dtype)
Expand All @@ -380,6 +377,10 @@ def make_zeros_aux(leaf):
# Now the diffusion related stuff
# Brownian increment (and space-time Lévy area)
bm_inc = diffusion.contr(t0, t1, use_levy=True)

# time increment
h = bm_inc.dt

if not isinstance(bm_inc, self.minimal_levy_area):
raise ValueError(
f"The Brownian increment {bm_inc} does not have the "
Expand Down
Loading