feat: add tests for target creation and deletion (#102)

Author: parmesant

model.go

@@ -473,7 +473,39 @@ func Roleingestor(stream string) string {
 	return fmt.Sprintf(`[{"privilege": "ingestor", "resource": {"stream": "%s"}}]`, stream)
 }
 
-func getAlertBody(stream string) string {
+func getTargetBody() string {
+	return `          {
+              "type": "webhook",
+              "endpoint": "https://webhook.site/ec627445-d52b-44e9-948d-56671df3581e",
+              "headers": {},
+              "skipTlsCheck": true,
+              "repeat": {
+                  "interval": "1m",
+                  "times": 1
+              }
+          }
+`
+}
+
+func getIdFromTargetResponse(body io.Reader) string {
+	type TargetConf struct {
+		Type         string `json:"type"`
+		Endpoint     string `json:"endpoint"`
+		Headers      string `json:"headers"`
+		SkipTlsCheck string `json:"skipTlsCheck"`
+		Repeat       string `json:"repeat"`
+		Id           string `json:"id"`
+	}
+	var response []TargetConf
+	if err := json.NewDecoder(body).Decode(&response); err != nil {
+		fmt.Printf("Error decoding: %v\n", err)
+	}
+
+	target := response[0]
+	return target.Id
+}
+
+func getAlertBody(stream string, targetId string) string {
 	return fmt.Sprintf(`
     {
       "severity": "medium",
@@ -508,18 +540,9 @@ func getAlertBody(stream string) string {
           }
       },
       "targets": [
-          {
-              "type": "webhook",
-              "endpoint": "https://webhook.site/ec627445-d52b-44e9-948d-56671df3581e",
-              "headers": {},
-              "skipTlsCheck": true,
-              "repeat": {
-                  "interval": "1m",
-                  "times": 1
-              }
-          }
+          "%s"
       ]
-    }`, stream)
+    }`, stream, targetId)
 }
 
 func getIdStateFromAlertResponse(body io.Reader) (string, string) {
@@ -544,7 +567,7 @@ func getIdStateFromAlertResponse(body io.Reader) (string, string) {
 	return alert.Id, alert.State
 }
 
-func createAlertResponse(id string, state string, stream string) string {
+func createAlertResponse(id string, state string, stream string, targetId string) string {
 	return fmt.Sprintf(`
   [{
     "version": "v1",
@@ -584,16 +607,7 @@ func createAlertResponse(id string, state string, stream string) string {
         }
     },
     "targets": [
-        {
-            "type": "webhook",
-            "endpoint": "https://webhook.site/ec627445-d52b-44e9-948d-56671df3581e",
-            "headers": {},
-            "skipTlsCheck": true,
-            "repeat": {
-                "interval": "1m",
-                "times": 1
-            }
-        }
+        "%s"
     ]
-  }]`, id, state, stream)
+  }]`, id, state, stream, targetId)
 }

quest_test.go

@@ -374,33 +374,58 @@ func TestSmokeLoad_CustomPartition_WithK6Stream(t *testing.T) {
 // 	DeleteStream(t, NewGlob.QueryClient, custom_partition_stream)
 // }
 
+func TestSmokeSetTarget(t *testing.T) {
+	CreateStream(t, NewGlob.QueryClient, NewGlob.Stream)
+	if NewGlob.IngestorUrl.String() == "" {
+		// RunFlog(t, NewGlob.QueryClient, NewGlob.Stream)
+		body := getTargetBody()
+		req, _ := NewGlob.QueryClient.NewRequest("POST", "/targets", strings.NewReader(body))
+		response, err := NewGlob.QueryClient.Do(req)
+		require.NoErrorf(t, err, "Request failed: %s", err)
+		require.Equalf(t, 200, response.StatusCode, "Server returned http code: %s and response: %s", response.Status, readAsString(response.Body))
+	}
+}
+
 func TestSmokeSetAlert(t *testing.T) {
 	CreateStream(t, NewGlob.QueryClient, NewGlob.Stream)
 	if NewGlob.IngestorUrl.String() == "" {
 		RunFlog(t, NewGlob.QueryClient, NewGlob.Stream)
-		body := getAlertBody(NewGlob.Stream)
-		req, _ := NewGlob.QueryClient.NewRequest("POST", "/alerts", strings.NewReader(body))
+		req, _ := NewGlob.QueryClient.NewRequest("GET", "/targets", nil)
 		response, err := NewGlob.QueryClient.Do(req)
 		require.NoErrorf(t, err, "Request failed: %s", err)
+		bodyTargets, _ := io.ReadAll(response.Body)
+		reader1 := bytes.NewReader(bodyTargets)
+		targetId := getIdFromTargetResponse(reader1)
+		body := getAlertBody(NewGlob.Stream, targetId)
+		req, _ = NewGlob.QueryClient.NewRequest("POST", "/alerts", strings.NewReader(body))
+		response, err = NewGlob.QueryClient.Do(req)
+		require.NoErrorf(t, err, "Request failed: %s", err)
 		require.Equalf(t, 200, response.StatusCode, "Server returned http code: %s and response: %s", response.Status, readAsString(response.Body))
 
 	}
 }
 
 func TestSmokeGetAlert(t *testing.T) {
 	if NewGlob.IngestorUrl.String() == "" {
-		req, _ := NewGlob.QueryClient.NewRequest("GET", "/alerts", nil)
+		req, _ := NewGlob.QueryClient.NewRequest("GET", "/targets", nil)
 		response, err := NewGlob.QueryClient.Do(req)
 		require.NoErrorf(t, err, "Request failed: %s", err)
+		bodyTargets, _ := io.ReadAll(response.Body)
+		reader1 := bytes.NewReader(bodyTargets)
+		targetId := getIdFromTargetResponse(reader1)
+		req, _ = NewGlob.QueryClient.NewRequest("GET", "/alerts", nil)
+		response, err = NewGlob.QueryClient.Do(req)
+		require.NoErrorf(t, err, "Request failed: %s", err)
 		body, _ := io.ReadAll(response.Body)
-		reader1 := bytes.NewReader(body)
+		reader1 = bytes.NewReader(body)
 		reader2 := bytes.NewReader(body)
 		expected := readAsString(reader1)
 		id, state := getIdStateFromAlertResponse(reader2)
 		require.Equalf(t, 200, response.StatusCode, "Server returned http code: %s and response: %s", response.Status, body)
-		res := createAlertResponse(id, state, NewGlob.Stream)
+		res := createAlertResponse(id, state, NewGlob.Stream, targetId)
 		require.JSONEq(t, expected, res, "Get alert response doesn't match with Alert config returned")
 		DeleteAlert(t, NewGlob.QueryClient, id)
+		DeleteTarget(t, NewGlob.QueryClient, targetId)
 	}
 	DeleteStream(t, NewGlob.QueryClient, NewGlob.Stream)
 }

test_utils.go

@@ -123,6 +123,13 @@ func DeleteAlert(t *testing.T, client HTTPClient, alert_id string) {
 	require.Equalf(t, 200, response.StatusCode, "Server returned http code: %s", response.Status)
 }
 
+func DeleteTarget(t *testing.T, client HTTPClient, target_id string) {
+	req, _ := client.NewRequest("DELETE", "targets/"+target_id, nil)
+	response, err := client.Do(req)
+	require.NoErrorf(t, err, "Request failed: %s", err)
+	require.Equalf(t, 200, response.StatusCode, "Server returned http code: %s", response.Status)
+}
+
 func RunFlog(t *testing.T, client HTTPClient, stream string) {
 	cmd := exec.Command("flog", "-f", "json", "-n", "50")
 	var out strings.Builder