Add initialize flags and pReserved to CInitializeArgs #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placintaalexandru
force-pushed
the
Add-pReserved-to-initialize-args
branch
from
3abf58e to
6ff1f0a
Compare
hug-dev
previously approved these changes
Dec 3, 2025
Member
hug-dev
left a comment
hug-dev
left a comment
There was a problem hiding this comment.
Thanks for the changes, it looks good to me! Just a small doc comment
placintaalexandru
force-pushed
the
Add-pReserved-to-initialize-args
branch
from
6ff1f0a to
f429b59
Compare
Author
I fixed it, my bad |
Jakuje
reviewed
Dec 8, 2025
Signed-off-by: Alexandru Placinta <placintaalexandru1@gmail.com>
placintaalexandru
force-pushed
the
Add-pReserved-to-initialize-args
branch
from
84c7d88 to
12df171
Compare
Jakuje
reviewed
Dec 8, 2025
Collaborator
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
Change looks reasonable. Though I am not much happy about breaking the API of the initialize() function as it means all the applications will have to be changed to use the new API.
Even though it looks like one simple change, if they accumulate and they span over several dependencies that need to be updated, its something that goes from mildly annoying to quite a complex problem to solve.
That said, I would prefer to keep the old API working if at least a bit possible (even marking deprecated would be ok).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#321