Skip to content

Commit fe4c102

Browse files
committed
temporarily rename models.py->pmodels.py due to conflicting with webui import of its own models.py, change job_timeout default back to 3 and make persistent, UI comp. for job timeout shows wrong default value
1 parent 7445cce commit fe4c102

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

scripts/spartan/UI.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ def save_btn(self, thin_client_mode, job_timeout):
8181
job_timeout = int(job_timeout)
8282
self.world.job_timeout = job_timeout
8383
logger.debug(f"job timeout is now {job_timeout} seconds")
84+
self.world.save_config()
8485

8586
def save_worker_btn(self, label, address, port, tls, disabled):
8687
"""creates or updates the worker selected in the worker config tab"""

scripts/spartan/Worker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
except ImportError: # webui 95821f0132f5437ef30b0dbcac7c51e55818c18f and newer
2121
from modules.initialize_util import gradio_server_name
2222
server_name = gradio_server_name()
23-
from .models import Worker_Model
23+
from .pmodels import Worker_Model
2424

2525

2626
class InvalidWorkerResponse(Exception):

scripts/spartan/World.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import modules.shared as shared
1919
from .Worker import Worker, State
2020
from .shared import logger, warmup_samples
21-
from .models import Config_Model, Benchmark_Payload
21+
from .pmodels import Config_Model, Benchmark_Payload
2222
from . import shared as sh
2323

2424

@@ -79,7 +79,7 @@ def __init__(self, initial_payload, verify_remotes: bool = True):
7979
self.total_batch_size: int = 0
8080
self._workers: List[Worker] = [self.master_worker]
8181
self.jobs: List[Job] = []
82-
self.job_timeout: int = 6 # seconds
82+
self.job_timeout: int = 3 # seconds
8383
self.initialized: bool = False
8484
self.verify_remotes = verify_remotes
8585
self.initial_payload = copy.copy(initial_payload)
@@ -544,6 +544,7 @@ def load_config(self):
544544
self.add_worker(**fields)
545545

546546
sh.benchmark_payload = Benchmark_Payload(**config.benchmark_payload)
547+
self.job_timeout = config.job_timeout
547548

548549
logger.debug("config loaded")
549550

@@ -554,7 +555,8 @@ def save_config(self):
554555

555556
config = Config_Model(
556557
workers=[{worker.label: worker.model.dict()} for worker in self._workers],
557-
benchmark_payload=sh.benchmark_payload
558+
benchmark_payload=sh.benchmark_payload,
559+
job_timeout=self.job_timeout
558560
)
559561

560562
with open(self.config_path, 'w+') as config_file:
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class Benchmark_Payload(BaseModel):
1010
batch_size: int = Field(default=1)
1111

1212
class Worker_Model(BaseModel):
13-
avg_ipm: float | None = Field(
13+
avg_ipm: Optional[float] = Field(
1414
title='Average Speed',
1515
description='the speed of a device measured in ipm(images per minute)',
1616
ge=0
@@ -35,4 +35,5 @@ class Config_Model(BaseModel):
3535
benchmark_payload: Dict = Field(
3636
default=Benchmark_Payload,
3737
description='the payload used when benchmarking a node'
38-
)
38+
)
39+
job_timeout: Optional[int] = Field(default=3)

0 commit comments

Comments
 (0)